Bug #57415
Local driver does not sanitize directory names on recursive creation
| Status: | Resolved | Start date: | 2014-03-28 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | - | % Done: | 100% |
|
| Category: | File Abstraction Layer (FAL) | Spent time: | - | |
| Target version: | - | |||
| TYPO3 Version: | 6.2 | Is Regression: | Yes | |
| PHP Version: | 5.4 | Sprint Focus: | ||
| Complexity: | no-brainer |
Description
The createFolder() method will not correctly sanitize the directory name parts, when the recursive option is TRUE (as used by TCE).
The reason for this is, that the return value of array_map is not used:
Regression introduced in #54230
Related issues
Associated revisions
[BUGFIX] Use return values of array_map in local driver
The LocalDriver will now use the return values of array_map calls in
createFolder() and determineBaseUrl() so that the values are really
sanitized / url encoded.
Resolves: #57415
Releases: 6.2
Change-Id: I8aa1a79c6e4a7fe6c2d82ec66c12338e75a35872
Reviewed-on: https://review.typo3.org/28940
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Markus Klein
Tested-by: Markus Klein
History
#1 Updated by Alexander Stehlik over 1 year ago
Actually there should be code in the description:
array_map(array($this, 'sanitizeFileName'), $parts);
#2 Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28940
#3 Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28940
#4 Updated by Alexander Stehlik over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 25c60e4478f97036df56563071873c5fcf683147.