Bug #58484

SoftReferenceIndex typolink missing support for more values in class attribute

Added by Marc Bastian Heinrichs over 1 year ago. Updated over 1 year ago.

Status:Resolved Start date:2014-05-04
Priority:Should have Due date:
Assigned To:- % Done:

100%

Category:- Spent time: -
Target version:next-patchlevel
TYPO3 Version:4.5 Is Regression:No
PHP Version: Sprint Focus:
Complexity:

Related issues

related to Core - Task #56580: SoftReferenceIndex typolink missing support for title att... Resolved 2014-03-05
related to Core - Bug #58503: Broken Functional Test: ExportTest::exportPagesAndRelated... Resolved 2014-05-04

Associated revisions

Revision a1a7dc0d
Added by Marc Bastian Heinrichs over 1 year ago

[BUGFIX] SoftReferenceIndex support for more values in class attribute

The SoftReferenceIndex parses and rebuilds typolink tags, but the
support for more than one value in class attribute is missing, because
the values don't get enclosed with quotes on rebuilding.
This leads to lost classes in typolinks in exports from impexp.

Resolves: #58484
Releases: 6.2, 6.1, 4.5
Change-Id: I12ed3be7f5be36254bcee57fcb24bf2a10f92f46
Reviewed-on: https://review.typo3.org/29846
Reviewed-by: Wouter Wolters
Reviewed-by: Sascha Wilking
Tested-by: Sascha Wilking
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Revision 05ef8fec
Added by Marc Bastian Heinrichs over 1 year ago

[BUGFIX] SoftReferenceIndex support for more values in class attribute

The SoftReferenceIndex parses and rebuilds typolink tags, but the
support for more than one value in class attribute is missing, because
the values don't get enclosed with quotes on rebuilding.
This leads to lost classes in typolinks in exports from impexp.

Resolves: #58484
Releases: 6.2, 6.1, 4.5
Change-Id: I12ed3be7f5be36254bcee57fcb24bf2a10f92f46
Reviewed-on: https://review.typo3.org/29852
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Revision 8ae7a4b9
Added by Markus Klein over 1 year ago

[BUGFIX] Fix broken impexp functional test

Issue #58484 fixed the inclusion of CSS classes
in typolinks, but did not adjust the tests.
Update the affected fixture data.

Resolves: #58503
Releases: 6.2
Change-Id: I511847bda3e393f104f1f141fb3a0bed4a97c1b1
Reviewed-on: https://review.typo3.org/29854
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs

Revision ac895911
Added by Markus Klein over 1 year ago

[BUGFIX] Fix broken impexp functional tests

Issue #58484 fixed the inclusion of CSS class
attributes in typolinks, but did not adjust the
impexp tests. Update the affected fixture data.

Resolves: #58503
Releases: 6.2
Change-Id: Ib71d50d03d045db37cd411523b54f8c6a1837833
Reviewed-on: https://review.typo3.org/29857
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs

Revision 81e31f18
Added by Marc Bastian Heinrichs about 1 year ago

[BUGFIX] SoftReferenceIndex support for more values in class attribute

The SoftReferenceIndex parses and rebuilds typolink tags, but the
support for more than one value in class attribute is missing, because
the values don't get enclosed with quotes on rebuilding.
This leads to lost classes in typolinks in exports from impexp.

Resolves: #58484
Releases: 6.2, 6.1, 4.5
Change-Id: I12ed3be7f5be36254bcee57fcb24bf2a10f92f46
Reviewed-on: https://review.typo3.org/29853
Reviewed-by: Markus Klein
Tested-by: Markus Klein

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29846

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29852

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_4-5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29853

#4 Updated by Marc Bastian Heinrichs over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF