Task #58735

Epic #58282: Workspaces Workpackage #2

Story #58284: Bug fixes & Behaviour

MM relations are not correctly resolved in Backend view

Added by Georg Ringer about 1 year ago. Updated about 1 year ago.

Status:Resolved Start date:2014-05-12
Priority:Must have Due date:
Assigned To:Oliver Hader % Done:

100%
Category:Workspaces Spent time: -
Target version:next-patchlevel
TYPO3 Version:6.2 Complexity:
PHP Version:5.4 Sprint Focus:

Description

There are some issues concering relations to mm tables.

As an example:
  • Create a page in live
  • Create some sys_category records
  • Switch to a workspace
  • Try to add relations to the categories inside the page
  • save
  • => nothing is selected
Example 2:
  • Create a page in live
  • Create some sys_category records
  • Add relations to categories inside the page
  • Switch to a workspace
  • => you see the relations of the live page, [ok]
  • change some relations
  • save
  • => no change has been done.

this is not bound to sys_categories or the tree implementation as this also doesn't work with a default 'select' rendermode.

suggestion by ohader via skype:

------------
das liegt aus meiner sicht am RelationHandler::getFromDB, hier fehlt das clean-up für workspace/non-workspace

Associated revisions

Revision 624aef35
Added by Oliver Hader about 1 year ago

[BUGFIX] MM relations are not correctly resolved in Backend view

DataPreprocessor is taking care of preparing data for the form
view processed in the FormEngine. However, MM relations are not
correctly resolved in a workspace context.

The method DataPreprocessor::getDataIdList() is used for a mixed
kind of relations there, without properly applying the differences
for MM records. The rule is, to always use the live default id,
except for MM relations - use the specific workspace value.

Resolves: #58735
Releases: 6.2
Change-Id: I256969adb46bfea80681160e2901387a8c7c9a7d
Reviewed-on: https://review.typo3.org/30037
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

History

#1 Updated by Oliver Hader about 1 year ago

My first guess was wrong, it's not RelationHandler::getFromDB() but a wrong for MM relations in the DataPreprocessor::getDataIdList() method - it's used for many kind of relations without properly applying the differences for MM records.

#2 Updated by Oliver Hader about 1 year ago

  • Subject changed from Severe issues with mm records and workspaces to MM relations are not correctly resolved in Backend view

#3 Updated by Gerrit Code Review about 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30037

#4 Updated by Oliver Hader about 1 year ago

  • Is Regression changed from No to Yes

#5 Updated by Oliver Hader about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF