Task #59112

Epic #58282: Workspaces Workpackage #2

Story #58284: Bug fixes & Behaviour

IRRE sorting not reflected

Added by Oliver Hader about 1 year ago. Updated 28 days ago.

Status:Under Review Start date:2014-05-26
Priority:Should have Due date:
Assigned To:Alexander Opitz % Done:

0%
Category:Workspaces Spent time: -
Target version:6.2.15
TYPO3 Version:6.2 Complexity:hard
PHP Version:5.3 Sprint Focus:

Description

Changing the IRRE element sorting might happen during editing the parent record or directly in the list view.
However, changed sorting is updated in the database but not visualized in the view. Besides that, move-placeholder are not filtered before handing over to the FormEngine.

Bildschirmfoto_2014-05-26_um_12.53.46.png (30.6 kB) Oliver Hader, 2014-05-26 12:55

59112.patch Magnifier (759 Bytes) Andreas Kiessling, 2014-10-16 09:58

59112_v2.patch Magnifier (768 Bytes) Andreas Kiessling, 2014-10-16 14:35

Related issues

related to Core - Bug #62957: Sorting of files in file links can´t be saved in draft wo... Closed 2014-11-14

History

#1 Updated by Simon Apold about 1 year ago

I can confirm this issue.

To reproduce the problem follow these steps:
  • clean TYPO3 6.2.4 installation
  • install workspace-extension
  • create a new workspace
  • in the live workspace create a new page with an image content element and add several images to it
  • switch to the new created workspace and edit the image content element
  • change the order of the images ans save the content element

Neither in the backend nor in the frontend view the changed sorting will take effect. It will show the order of the live workspace.

#2 Updated by Andreas Kiessling 10 months ago

I also confirm this issue, just tested it with a fresh git checkout.
Reordering inline elements worked in 4.x. Any idea, where to start debugging?

#3 Updated by Andreas Kiessling 10 months ago

I think the problem comes from the change, that the relations now always point to the uid of the live record. I don't think, that the ordering can be determined through SQL, too much overlaying is applied to the records in PHP. The order is properly saved to the DB, but if you save the parent record again, the wrong order gets saved.

The attached patch seems to fix the issue for my 1:n relations and sys_file_references.

But you also need to do the same for all frontend logic! In 4.x, it was enough to determine the right uid to use for fetching the related records, e.g.
uid, _LOCALIZED_UID or _ORIG_uid (if you don't need any l10n overlays) Now you need to do the sorting afterwards

#4 Updated by Andreas Kiessling 10 months ago

Is it safe to rely on $relatedRecords['count']? Sorting should only be done, if there is more then one record, see v2

#5 Updated by Mathias Schreiber 6 months ago

  • Target version set to 7.5

#6 Updated by Gerrit Code Review 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39901

#7 Updated by Alexander Opitz 2 months ago

  • Status changed from Under Review to New
  • Assigned To set to Alexander Opitz

#8 Updated by Alexander Opitz 2 months ago

  • Status changed from New to Under Review

#9 Updated by Alexander Opitz about 1 month ago

  • Target version changed from 7.5 to 6.2.14

#10 Updated by Alexander Opitz 28 days ago

  • Target version changed from 6.2.14 to 6.2.15

Also available in: Atom PDF