Bug #59404
Sub-Requests losing arguments
| Status: | Resolved | Start date: | 2014-06-07 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Carsten Bleicker | % Done: | 100% |
|
| Category: | MVC | |||
| Target version: | TYPO3 Flow Base Distribution - 2.x | |||
| PHP Version: | Complexity: | |||
| Has patch: | No | Affected Flow version: | Git master |
Description
A sub-request losing its arguments it a route is defined with defaults.
201409211409527b16a6.txt
(16.6 kB)
Associated revisions
[BUGFIX] Merge request arguments instead of overwrite
A sub-request losing its arguments if a route is defined f.e. like this:
-
name: 'Basket Steps'
uriPattern: '{node}/{--pipeu_factura_nodetypes-basket.@action}.{@format}'
defaults:
'@package': 'TYPO3.Neos'
'@controller': 'Frontend\Node'
'@format': 'html'
'@action': 'show'
'--pipeu_factura_nodetypes-basket':
'@package': 'PIPEU.Factura.NodeTypes'
'@controller': 'Basket'
routeParts:
node:
handler: TYPO3\Neos\Routing\FrontendNodeRoutePartHandler
appendExceedingArguments: true
In this case '--pipeu_factura_nodetypes-basket' will override
any pluginArgument because of a missing check for existing
index in pluginArguments. Its getting replaced instead of merged.
This wrong behavior is fixed with this patch by merging instead of
overwriting.
Same for internal arguments.
Was fixed in master by the related feature.
Related: I1d192231810757f38aecfc3f7dc520b118ee3feb
Change-Id: Ib067912327cb07cc6fff91d1fe5b3e5c6cd9ccdb
Resolves: #59404
Releases: master, 2.2, 2.1
[BUGFIX] Merge request arguments instead of overwrite
A sub-request losing its arguments if a route is defined f.e. like this:
-
name: 'Basket Steps'
uriPattern: '{node}/{--pipeu_factura_nodetypes-basket.@action}.{@format}'
defaults:
'@package': 'TYPO3.Neos'
'@controller': 'Frontend\Node'
'@format': 'html'
'@action': 'show'
'--pipeu_factura_nodetypes-basket':
'@package': 'PIPEU.Factura.NodeTypes'
'@controller': 'Basket'
routeParts:
node:
handler: TYPO3\Neos\Routing\FrontendNodeRoutePartHandler
appendExceedingArguments: true
In this case '--pipeu_factura_nodetypes-basket' will override
any pluginArgument because of a missing check for existing
index in pluginArguments. Its getting replaced instead of merged.
This wrong behavior is fixed with this patch by merging instead of
overwriting.
Same for internal arguments.
Was fixed in master by the related feature.
Related: I1d192231810757f38aecfc3f7dc520b118ee3feb
Change-Id: Ib067912327cb07cc6fff91d1fe5b3e5c6cd9ccdb
Resolves: #59404
Releases: master, 2.2, 2.1
History
#1 Updated by Gerrit Code Review about 1 year ago
- Status changed from New to Under Review
Patch set 6 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/30562
#2 Updated by Gerrit Code Review about 1 year ago
Patch set 7 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/30562
#3 Updated by Gerrit Code Review about 1 year ago
Patch set 8 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/30562
#4 Updated by Gerrit Code Review 12 months ago
Patch set 9 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at http://review.typo3.org/30562
#5 Updated by Gerrit Code Review 11 months ago
Patch set 10 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at http://review.typo3.org/30562
#6 Updated by Carsten Bleicker 11 months ago
- File 201409211409527b16a6.txt added
Provided a Site Package wich let you see the problem and the resulting exception.
Please see: https://bitbucket.org/cbleicker/typo3.neosdemotypo3org/src/5dea4b055946488b5e905a480243fa3feb0e705c?at=develop
You need to enable the routes of the site package to reproduce it.
Please see Line 19 of:
https://bitbucket.org/cbleicker/typo3.neosdemotypo3org/src/5dea4b055946488b5e905a480243fa3feb0e705c/Configuration/Routes.yaml?at=develop#cl-19
Site export contains a new page node called "Basket" wich has a plugin to show the behaviour.
#7 Updated by Gerrit Code Review 10 months ago
Patch set 1 for branch 2.2 of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at http://review.typo3.org/33050
#8 Updated by Gerrit Code Review 10 months ago
Patch set 1 for branch 2.1 of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at http://review.typo3.org/33051
#9 Updated by Christian Müller 9 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 7e643f7b00ed624b8385f5f02f2862eaba43d40c.