Task #59616

Story #58777: Fixes/Tasks for impexp / distributions

Import forces pid 0 if rootLevel = -1 is set in TCA

Added by Simplicity GmbH about 1 year ago. Updated 5 months ago.

Status:Resolved Start date:2014-06-16
Priority:Should have Due date:
Assigned To:Marc Bastian Heinrichs % Done:

100%
Category:Import/Export (T3D) Spent time: -
Target version:-
TYPO3 Version:6.2 Complexity:
PHP Version: Sprint Focus:

Description

Hi

When importing tx_gridelements_backend_layout records they are "forced" to the root level (pid=0).

Warnings in preview:
TABLE 'tx_gridelements_backend_layout' will be inserted on ROOT LEVEL!

I tried several export settings without success. Then I noticed that in Ext:gridelements rootLevel=-1 is set for this table. (in TCA, ext_tables.php)

When I change it to rootLevel=0 or remove the entry it is possible to import records into a sysfolder (which is included in the same .t3d file).

It seems impexp does not respect -1 (= allow record on root level and normal pages). If it would handle -1 the same way as it does when rootLevel is not set at all it would work in our case. But we don't need/want to import records to the root level.

Regards, Pascal

import-message.jpg (135.8 kB) Simplicity GmbH, 2014-08-21 00:33

Associated revisions

Revision 0e7acd5a
Added by Marc Bastian Heinrichs 5 months ago

[BUGFIX] Fix wrong enforcement of pid 0 for rootLevel = -1 in impexp

The importer had no support for setting TCA ctrl rootLevel = -1 and
forces the import to pid 0, when a normal page id is also allowed.

Resolves: #59616
Releases: master, 6.2
Change-Id: I224a6d0065c2031636fce494924fc892541ab350
Reviewed-on: http://review.typo3.org/31066
Reviewed-by: Frans Saris <>
Tested-by: Frans Saris <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 089417cb
Added by Marc Bastian Heinrichs 5 months ago

[BUGFIX] Fix wrong enforcement of pid 0 for rootLevel = -1 in impexp

The importer had no support for setting TCA ctrl rootLevel = -1 and
forces the import to pid 0, when a normal page id is also allowed.

Resolves: #59616
Releases: master, 6.2
Change-Id: I224a6d0065c2031636fce494924fc892541ab350
Reviewed-on: http://review.typo3.org/37838
Reviewed-by: Frans Saris <>
Tested-by: Frans Saris <>

History

#1 Updated by Markus Klein about 1 year ago

  • Assigned To set to Marc Bastian Heinrichs

@MaBa: Can you please check on that? Thx

#2 Updated by Marc Bastian Heinrichs about 1 year ago

  • Status changed from New to Accepted

#3 Updated by Marc Bastian Heinrichs about 1 year ago

  • Parent task set to #58777

#4 Updated by Gerrit Code Review about 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31066

#5 Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31066

#6 Updated by Simplicity GmbH 12 months ago

It works with the patch. Gridelements are imported into the selected sysfolder now.

But I was confused at first because the alert message was still shown. Screenshot attached.
I tried it anyway and it worked.

After cloning TYPO3 I used the following link to checkout the patch. I'm not very familiar with git (yet), maybe I downloaded the wrong patch.
git fetch http://review.typo3.org/Packages/TYPO3.CMS refs/changes/66/31066/2 && git checkout FETCH_HEAD

#7 Updated by Gerrit Code Review 11 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31066

#8 Updated by Gerrit Code Review 9 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31066

#9 Updated by Gerrit Code Review 5 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31066

#10 Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37838

#11 Updated by Marc Bastian Heinrichs 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12 Updated by Gerrit Code Review 5 months ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37838

#13 Updated by Marc Bastian Heinrichs 5 months ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF