Bug #59831
Package loading order is currupted by faulty patch #59147
| Status: | Resolved | Start date: | 2014-06-24 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Markus Klein | % Done: | 100% |
|
| Category: | Package Manager | Spent time: | - | |
| Target version: | next-patchlevel | |||
| TYPO3 Version: | 6.2 | Is Regression: | Yes | |
| PHP Version: | Sprint Focus: | |||
| Complexity: | medium |
Description
The path saved to packagePathStack contains the package name, but is compared to the storage folder only.
Moreover the EM fails upon removing extensions, as we do not persist the packagePathStack information, we would need for that case. :-(
Related issues
Associated revisions
Revert "[BUGFIX] Fix loading order for extensions"
This reverts commit 49b53d491e43f3ad7a4c30dc23e208eb8db04199
The patch has two flaws:
* Easy: packagePathStack also includes package folder which
is incompatible to the excludedPaths search
* Nightmare: Upon uninstalling extensions the PackageManager
fails due to missing packagePathStack information
Change-Id: Ie026a90bd18ab86c355c17ae387df9249bc6b1c0
Resolves: #59831
Reverts: #59147
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31097
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Revert "[BUGFIX] Fix loading order for extensions"
This reverts commit c0779513b431b19413873893bf630aa3de6fc1fc
The patch has two flaws:
* Easy: packagePathStack also includes package folder which
is incompatible to the excludedPaths search
* Nightmare: Upon uninstalling extensions the PackageManager
fails due to missing packagePathStack information
Change-Id: I27642b3dea7541cb5f7363172edff147d34999d1
Resolves: #59831
Reverts: #59147
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31098
Reviewed-by: Markus Klein
Tested-by: Markus Klein
History
#1 Updated by Gerrit Code Review about 1 year ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31097
#2 Updated by Gerrit Code Review about 1 year ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31098
#3 Updated by Markus Klein about 1 year ago
- Status changed from Under Review to Accepted
#4 Updated by Markus Klein about 1 year ago
- Status changed from Accepted to Under Review
#5 Updated by Markus Klein about 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset f1c270a7a0ac3653d9e823d63d466d60f43d0bd4.
#6 Updated by Kasper Ligaard about 1 year ago
Is there a fair chance this will be solved within the coming weeks? I can live fine without the package-stuff (and I think most TYPO3 users would too), as long as it is made to work with TYPO3 extensions.
As it is right now, it is a nightmare to reliably use the Extension Manager - and it has been like that ever since October 2013, when the package-stuff was merged in to core :-(
PS: Is there an issue about printing the loading order within the Extension Manager (like there was in previous Extension Managers)?
#7 Updated by Markus Klein about 1 year ago
- Status changed from Resolved to Accepted
@Kasper, are you talking about #59147?
Please read my comments there.
Please do not post to this issue here, it is just here to document the revert of the original patch.
#8 Updated by Markus Klein about 1 year ago
- Status changed from Accepted to Resolved