Bug #59972
Invalid mergeIfNotBlank usage in sys_file_reference TCA
| Status: | Resolved | Start date: | 2014-06-29 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | - | % Done: | 100% |
|
| Category: | Backend User Interface | Spent time: | - | |
| Target version: | next-patchlevel | |||
| TYPO3 Version: | 6.2 | Is Regression: | No | |
| PHP Version: | 5.4 | Sprint Focus: | ||
| Complexity: | easy |
Description
Some fields in the sys_file_reference table currently are configured to behave as "mergeIfNotBlank" but this behavior is not respected in the Frontend. (and would not make sense there either).
Imagine this: You have a file and its metadata is translated in English and German.
Now you override the German translation in the file reference.
You probably do not want to use the german override for the English version. But you might want to remove the English description. The rendering in the Frontend currently behaves exactly like this. This is why the "mergeIfNotBlank" setting should be removed from the TCA to prevent confusion.
Related issues
Associated revisions
[BUGFIX] Improve l10n_mode config for sys_file_reference
Since the rendering in the Frontend does not merge the values
the mergeIfNotBlank setting is replaced with prefixLangTitle for
the alternative, description and title field.
For the link field the mergeIfNotBlank setting is removed because
a prefix does not make sense there.
Releases: 6.3, 6.2
Resolves: #59972
Change-Id: I242b687a7ce851270022b86561f13eacea4d3949
Reviewed-on: http://review.typo3.org/31212
Reviewed-by: Marcin Sągol <marcin@soee.pl>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
[BUGFIX] Improve l10n_mode config for sys_file_reference
Since the rendering in the Frontend does not merge the values
the mergeIfNotBlank setting is replaced with prefixLangTitle for
the alternative, description and title field.
For the link field the mergeIfNotBlank setting is removed because
a prefix does not make sense there.
Releases: 6.3, 6.2
Resolves: #59972
Change-Id: I242b687a7ce851270022b86561f13eacea4d3949
Reviewed-on: http://review.typo3.org/32756
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
[BUGFIX] Improve l10n_mode config for sys_file_reference
Since the rendering in the Frontend does not merge the values
the mergeIfNotBlank setting is replaced with prefixLangTitle for
the alternative, description and title field.
For the link field the mergeIfNotBlank setting is removed because
a prefix does not make sense there.
Change-Id: I09dfd6d971357ceaeaa08f60057323b3c7e33aa1
Releases: master
Resolves: #59972
Reviewed-on: http://review.typo3.org/32758
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
History
#1 Updated by Gerrit Code Review about 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31212
#2 Updated by Gerrit Code Review about 1 year ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31212
#3 Updated by Gerrit Code Review about 1 year ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31212
#4 Updated by Gerrit Code Review 11 months ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32756
#5 Updated by Alexander Stehlik 11 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b013405328a679a2c22c885215e89edf1dba5327.
#6 Updated by Gerrit Code Review 11 months ago
- Status changed from Resolved to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32758
#7 Updated by Gerrit Code Review 9 months ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32758
#8 Updated by Markus Klein 7 months ago
- Description updated (diff)
- Target version set to next-patchlevel
- % Done changed from 100 to 0
Note: original patches have been reverted!
#9 Updated by Gerrit Code Review about 1 month ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32758
#10 Updated by Gerrit Code Review 24 days ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32758
#11 Updated by Alexander Stehlik 24 days ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 4143a9b4bf9169f373c4130dce262a611d88c781.