Bug #60343

Epic #58282: Workspaces Workpackage #2

Story #58284: Bug fixes & Behaviour

Metadata does not recognize workspace

Added by Gerhard Rupp about 1 year ago. Updated 8 months ago.

Status:Resolved Start date:2014-11-15
Priority:Must have Due date:
Assigned To:Helmut Hummel % Done:

100%
Category:Workspaces Spent time: -
Target version:-
TYPO3 Version:6.2 Is Regression:No
PHP Version:5.3 Sprint Focus:
Complexity:

Description

Metadata retrieved from table sys_file_metadata does not recognize workspaces. Therefore users in a draft workspace can´t make use of metadata. (Metadata of new files in the LIVE-workspace is empty by default of course.)

Subtasks

Bug #62986: No workspace preview for sys_file_metadataResolved

Related issues

duplicated by Core - Bug #62537: Fileadmin meta data in workspace (FAL) Closed 2014-10-29

Associated revisions

Revision 2a637539
Added by Helmut Hummel 9 months ago

[BUGFIX] Make sys_file_metadata publishable

Currently sys_file_metadata records that are edited in a workspace
cannot be published because the workspace module does not know
about ignored root level restrictions and these records are on
root level by definition.

Include the root page when searching for workspace records
and show elements for which root level restriction is ignored.

Resolves: #60343
Releases: 6.2, master
Change-Id: Ib82f5c7f7a67824c5d7d4e7cdaa01c89e0912731
Reviewed-on: http://review.typo3.org/34156
Tested-by: Gerhard Rupp <>
Reviewed-by: Alex Kellner <>
Tested-by: Alex Kellner <>
Reviewed-by: Markus Klein <>
Reviewed-by: Helmut Hummel <>
Tested-by: Helmut Hummel <>

Revision 8f06c8d6
Added by Helmut Hummel 9 months ago

[BUGFIX] Make sys_file_metadata publishable

Currently sys_file_metadata records that are edited in a workspace
cannot be published because the workspace module does not know
about ignored root level restrictions and these records are on
root level by definition.

Include the root page when searching for workspace records
and show elements for which root level restriction is ignored.

Resolves: #60343
Releases: 6.2, master
Change-Id: Ib82f5c7f7a67824c5d7d4e7cdaa01c89e0912731
Reviewed-on: http://review.typo3.org/34183
Reviewed-by: Helmut Hummel <>
Tested-by: Helmut Hummel <>

Revision 26f6bd7d
Added by Helmut Hummel 9 months ago

[BUGFIX] Make sys_file_metadata publishable

Currently sys_file_metadata records that are edited in a workspace
cannot be published because the workspace module does not know
about ignored root level restrictions and these records are on
root level by definition.

Include the root page when searching for workspace records
and show elements for which root level restriction is ignored.

Resolves: #60343
Releases: 6.2, master
Change-Id: I43a273661addff4a4e337bb464eb0cc4fd1fb823
Reviewed-on: http://review.typo3.org/34188
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>
Reviewed-by: Alex Kellner <>
Tested-by: Alex Kellner <>

Revision 7d43291a
Added by Helmut Hummel 9 months ago

[BUGFIX] Make sys_file_metadata publishable

Currently sys_file_metadata records that are edited in a workspace
cannot be published because the workspace module does not know
about ignored root level restrictions and these records are on
root level by definition.

Include the root page when searching for workspace records
and show elements for which root level restriction is ignored.

Resolves: #60343
Releases: 6.2, master
Change-Id: I43a273661addff4a4e337bb464eb0cc4fd1fb823
Reviewed-on: http://review.typo3.org/34270
Reviewed-by: Helmut Hummel <>
Tested-by: Helmut Hummel <>

History

#1 Updated by Alex Kellner 9 months ago

Hi,

I think I have the same issue here.
I try to describe it a bit more.

If you're using workspaces and have editors, you have to select DB-Mount-Points for the be_groups. You can let the DB-Mount-Points empty for workspaces but normally you would also select a page. Letting Mount-Points empty for groups had the effect, that the editor have no pages in pagetree. Selecting root is possible for both records as long as you click on save - after a reload "0" is removed.
This is the main issue. Because records of type sys_file_metadata have pid=0 per default. So the editor has no chance to publish a sys_file_metadata record in TYPO3

Configuration
  • TYPO3 6.2.6
  • Draft Workspace
  • BE-User (editor) with most available rights (really all tables)
How to reproduce
  • Editor change workspace to draft
  • Upload an image in filelist to any folder
  • Edit the record and save some title, altText, description
  • Editor will also create a new content record (type Image) with a relation to the uploaded image before
  • The default title of the image should be used (also description and altText)
  • The editor (or another editor) is going to publish the changes, but in Workspace Module only the new tt_content element is shown (not the metadata-record)
Workarround
  • A quick proof confirmed: Changing the pid of the metadata-record directly in the database to any existing page (where the publishing-editor has access to) will help. Now it's possible to publish both records
  • So, if I would create an extension with a small TCA configuration to extend sys_file_metadata, I could insert a value to field PID.

BTW: I'm not totally sure but I think ticket #62537 could be related to this one

#2 Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34156

#3 Updated by Gerrit Code Review 9 months ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34183

#4 Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34183

#5 Updated by Helmut Hummel 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Gerrit Code Review 9 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34188

#7 Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34188

#8 Updated by Gerrit Code Review 9 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34188

#9 Updated by Gerrit Code Review 9 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34188

#10 Updated by Oliver Hader 9 months ago

  • Parent task set to #58284

#11 Updated by Oliver Hader 9 months ago

  • Assigned To set to Helmut Hummel

#12 Updated by Gerrit Code Review 9 months ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34270

#13 Updated by Helmut Hummel 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF