Task #60857
Change fetch of maximum version from subselect to join
Status: | Resolved | Start date: | 2014-08-08 | |
---|---|---|---|---|
Priority: | Should have | Due date: | ||
Assigned To: | - | % Done: | 100% |
|
Category: | Extension Manager | Spent time: | - | |
Target version: | - | |||
TYPO3 Version: | 6.2 | Complexity: | easy | |
PHP Version: | Sprint Focus: |
Description
Currently, the method "fetchMaximalVersionsForAllExtensions" in typo3/sysext/extensionmanager/Classes/Domain/Repository/ExtensionRepository uses a subselect to determine the highest available version. This solution is rather inefficient and incomptabile to DBAL.
The query has been replaced by a LEFT JOIN according to http://dev.mysql.com/doc/refman/5.5/en/example-maximum-column-group-row.html.
Associated revisions
[TASK] Change fetch of maximum version using LEFT JOIN
Currently, the method fetchMaximalVersionsForAllExtensions uses a
subselect to determine the highest available version. This solution is
rather inefficient and incomptabile to DBAL. The query is replaced by
a LEFT JOIN.
Resolves: #60857
Releases: 6.2, 6.3
Change-Id: I7ae3c523259bf260c41080aee269f6df33edb408
Reviewed-on: http://review.typo3.org/32062
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
[TASK] Change fetch of maximum version using LEFT JOIN
Currently, the method fetchMaximalVersionsForAllExtensions uses a
subselect to determine the highest available version. This solution is
rather inefficient and incomptabile to DBAL. The query is replaced by
a LEFT JOIN.
Resolves: #60857
Releases: 6.2, 6.3
Change-Id: I7ae3c523259bf260c41080aee269f6df33edb408
Reviewed-on: http://review.typo3.org/32288
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
History
#1 Updated by Gerrit Code Review 12 months ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32062
#2 Updated by Gerrit Code Review 12 months ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32062
#3 Updated by Gerrit Code Review 12 months ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32062
#4 Updated by Gerrit Code Review 12 months ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32062
#5 Updated by Gerrit Code Review 12 months ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32062
#6 Updated by Gerrit Code Review 12 months ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32062
#7 Updated by Gerrit Code Review 12 months ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32062
#8 Updated by Gerrit Code Review 12 months ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32062
#9 Updated by Gerrit Code Review 12 months ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32062
#10 Updated by Gerrit Code Review 12 months ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32288
#11 Updated by Andreas Fernandez 12 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b859c8235094b1efd90e919405b640110914c45f.