Feature #61577
Feature #61471: Base EXT: t3skin on twbs less
Use HTML5 label+checkbox semantics
Status: | Resolved | Start date: | 2014-09-14 | |
---|---|---|---|---|
Priority: | Should have | Due date: | ||
Assigned To: | - | % Done: | 100% |
|
Category: | - | Spent time: | - | |
Target version: | - | |||
PHP Version: | Sprint Focus: | |||
Complexity: |
Description
There is no common mark-up in the CMS backend for checkbox+labels in forms.
With the inclusion of Bootstrap we decide for the Bootstrap HTML5 markup syntax in forms:
See http://getbootstrap.com/css/#forms for preview and mark-up.
Forms do not receive a special markup.
Normal forms without layout (not horizontal, not filter-bar, not inline) include this syntax:
<form role="form"> <div class="form-group"> <label for="text">Label text</label> <input type="file" id="text"> <p class="help-block">Example block-level help text here.</p> </div> <div class="checkbox"> <label> <input type="checkbox"> Check me out </label> </div> </form>
In this first step we migrate the checkbox html towards HTML5 mark-up:
- Wrap checkbox group within
<div class="checkbox"></div>
- Move Input field into the
<label>…</label>
- Move the label text into the
<label>…</label>
after the input checkbox
Why?
Ofter the checkbox and radio inputs are grouped and bring one description label for the group:
Behave like: [x] A
[-] B
Therefore the <label> tag is not formatted bold and the
<div class="checkbox">can also bring another group label.
Subtasks
Associated revisions
[FEATURE] Group-work for HTML5 [x] checkbox-label-groups
Kick-Off patch to bring semantic HTML5 for checkbox+label groups
in the backend. Bootstrap compatible HTML5 mark-up for improved
semantics.
Adapts Web>Page and Web>List and Tools>Config.
Resolves: #61577
Releases: master
Change-Id: Ia0f030a3e3970462390563722d51f0bb0d4eb4de
Reviewed-on: http://review.typo3.org/32762
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
[TASK] Change HTML code to match Bootstrap layout
Fix markup for checkbox in:- EditDocumentController.php
- FileListController.php
Resolves: #61579
Related: #61577
Releases: master
Change-Id: Ie49f75853bb9a5cbfeb9d44268f29655afbc2e49
Reviewed-on: http://review.typo3.org/32764
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
[TASK] Checkbox / label markup in create multiple pages
Fix markup in CreatePagesWizardModuleFunctionController
Resolves: #61581
Related: #61577
Releases: master
Change-Id: I05b646018c4e8bae7f2f55548c1bdc21820af551
Reviewed-on: http://review.typo3.org/32766
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
[TASK] Change HTML code to match Bootstrap layout
Fix markup for checkbox in:- QueryGenerator.php
- InfoPageTyposcriptConfigController.php
- ConfigurationView.php
- DatabaseIntegrityView.php
- TemplateAnalyzerModuleFunctionController.php
- TypoScriptTemplateInformationModuleFunctionController.php
- TypoScriptTemplateObjectBrowserModuleFunctionController.php
- TypoScriptTemplateModuleController.php
Resolves: #61584
Related: #61577
Releases: master
Change-Id: Ib4f6a55245d05cce2742b86c6381e9d73ee5de96
Reviewed-on: http://review.typo3.org/32770
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
History
#2 Updated by Gerrit Code Review 11 months ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32762
#3 Updated by Felix Kopp 11 months ago
These are the places I found more checkboxes:
+ Functions module / CreatePagesWizardModuleFunctionController / lines 130ff.
+ Info PageTS / InfoPageTyposcriptConfigController / lines ~70
#4 Updated by Felix Kopp 11 months ago
Checkbox
+ Edit record / FormEngine
+ Template
#5 Updated by Frank Nägler 11 months ago
+ Filelist > File listing
+ Backend User > Editi BE User > "Show secondary options (palettes)"
both will be fixed in https://forge.typo3.org/issues/61579
#6 Updated by Gerrit Code Review 11 months ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32762
#7 Updated by Gerrit Code Review 11 months ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32762
#8 Updated by Gerrit Code Review 11 months ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32762
#9 Updated by Felix Kopp 11 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset abb72b2f704f136251d05ae991967eeace5961a7.