Bug #62391

TYPO3 4.5.37 requires PHP 5.3

Added by Christian Hernmarck 10 months ago. Updated 9 months ago.

Status:Resolved Start date:2014-10-22
Priority:Must have Due date:
Assigned To:- % Done:

100%
Category:- Spent time: -
Target version:next-patchlevel
TYPO3 Version:4.5 Is Regression:Yes
PHP Version:5.2 Sprint Focus:
Complexity:no-brainer

Description

With PHP 5.2.6:

[22-Oct-2014 11:30:21] PHP Fatal error: func_get_args(): Can't be used as a function parameter in
..../typo3/typo3_src-4.5.37/t3lib/class.t3lib_div.php on line 5432

http://php.net/manual/en/function.func-get-arg.php:
Version Description
5.3.0 This function can now be used in parameter lists.

So - even if PHP 5.2 is deprecated, on the TYPO3-Download page it says TYPO3 4.5 runs with PHP 5.2 - but the update from today does not.

Related issues

related to Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interf... Resolved 2013-11-15
duplicated by Core - Bug #62409: TYPO3 4.5.37 not compatible with PHP 5.2.x Closed 2014-10-22

Associated revisions

Revision a62c19e5
Added by Helmut Hummel 10 months ago

[BUGFIX] Ensure PHP 5.2 compatibility in makeInstance

The backport #53682 introduced a regression with PHP 5.2,
which still is officially supported by TYPO3 CMS 4.5

Adapt the code to be PHP 5.2 compatible

Resolves: #62391
Releases: 4.5
Change-Id: Ie9d6c3175d02424e0d2329cc07ff99e09cccc040
Reviewed-on: http://review.typo3.org/33470
Reviewed-by: Christian Hernmarck <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 79ba8820
Added by Michael Stucki 9 months ago

[BUGFIX] Ensure PHP 5.2 compatibility in php-openid

The backport #62357 introduced a regression with PHP 5.2,
which still is officially supported by TYPO3 CMS 4.5

Adapt the code to be PHP 5.2 compatible

Resolves: #62391
Releases: 4.5
Change-Id: I72895592e10d963f2777c4659cc1f0a10e69a1c1
Reviewed-on: http://review.typo3.org/33737
Reviewed-by: Helmut Hummel <>
Tested-by: Helmut Hummel <>
Reviewed-by: Wouter Wolters <>

History

#1 Updated by Markus Klein 10 months ago

  • Status changed from New to Accepted
  • Is Regression changed from No to Yes

#2 Updated by Mathias Schreiber 10 months ago

Hi Christian,

you are absolutely right about this one.
I'm sorry a backport slipped through and broke 5.2 compatibility.
We are working on a solution right now.

Thank you for reporting the issue on such short notice.

Cheers
Mathias

#3 Updated by Gerrit Code Review 10 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_4-5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33470

#4 Updated by Markus Klein 10 months ago

  • Status changed from Under Review to Accepted
  • Priority changed from Should have to Must have
  • Complexity set to no-brainer

#5 Updated by Gerrit Code Review 10 months ago

  • Status changed from Accepted to Under Review

Patch set 2 for branch TYPO3_4-5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33470

#6 Updated by Gerrit Code Review 10 months ago

Patch set 3 for branch TYPO3_4-5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33470

#7 Updated by Helmut Hummel 10 months ago

  • Status changed from Under Review to Needs Feedback

Christian Hernmarck wrote:

So - even if PHP 5.2 is deprecated, on the TYPO3-Download page it says TYPO3 4.5 runs with PHP 5.2 - but the update from today does not.

Can you please test if https://review.typo3.org/#/c/33470/ resolves your issue with PHP 5.2? It works for me with PHP 5.2.17

#8 Updated by Christian Hernmarck 10 months ago

Patchset 2 or 3 (same..?) fixes the problem - I can login again :-)

Thx!

#9 Updated by Markus Klein 10 months ago

Please consider voting on Gerrit too. Thanks.

#10 Updated by Christian Hernmarck 10 months ago

not my daily job... but I think I succeded... :-)

#11 Updated by Oliver Hader 10 months ago

Thanks for reporting. Unfortunately the automated tests did not catch this behavior as well.

Travis was running (actually it was not running) but did not trigger an error warning:
https://travis-ci.org/TYPO3/TYPO3.CMS/builds/37984429

#12 Updated by Helmut Hummel 10 months ago

  • Status changed from Needs Feedback to Resolved
  • % Done changed from 0 to 100

#13 Updated by Gerrit Code Review 9 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33737

#14 Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch TYPO3_4-5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33737

#15 Updated by Gerrit Code Review 9 months ago

Patch set 3 for branch TYPO3_4-5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33737

#16 Updated by Michael Stucki 9 months ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF