Bug #62569

Function menu broken for old modules

Added by Helmut Hummel 9 months ago. Updated 9 months ago.

Status:Resolved Start date:2014-10-30
Priority:Should have Due date:
Assigned To:- % Done:

100%

Category:- Spent time: -
Target version:-
TYPO3 Version:6.2 Is Regression:No
PHP Version: Sprint Focus:
Complexity:

Description

The CSRF protection for backend modules (#55509) introduced a BC break which can be easily avoided


Related issues

related to Core - Story #55509: Add CSRF Protection to mod.php Resolved 2014-02-26

Associated revisions

Revision 737613db
Added by Helmut Hummel 9 months ago

[BUGFIX] Fix script URLs for traditional modules

The introduction of CSRF protection for backend modules
introduced a regression for traditional modules.

Previously the script was calculated correctly if
not provided. Now API calls without providing the script
are assumed to be mod.php dispatched.

Fix that by checking if the M GET argument was sent
and fall back to traditional URL calculation.

Resolves: #62569
Releases: 6.2, master
Change-Id: I26d16acb513d678f117e0b645fe3eefebf909e3d
Reviewed-on: http://review.typo3.org/33626
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 7c3b83f8
Added by Helmut Hummel 9 months ago

[BUGFIX] Fix script URLs for traditional modules

The introduction of CSRF protection for backend modules
introduced a regression for traditional modules.

Previously the script was calculated correctly if
not provided. Now API calls without providing the script
are assumed to be mod.php dispatched.

Fix that by checking if the M GET argument was sent
and fall back to traditional URL calculation.

Resolves: #62569
Releases: 6.2, master
Change-Id: I26d16acb513d678f117e0b645fe3eefebf909e3d
Reviewed-on: http://review.typo3.org/33707
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33626

#2 Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33626

#3 Updated by Gerrit Code Review 9 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33626

#4 Updated by Helmut Hummel 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Gerrit Code Review 9 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33707

#6 Updated by Helmut Hummel 9 months ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF