Bug #63380

FLUIDTEMPLATE: New fallback paths miss stdWrap

Added by Chris topher 8 months ago. Updated 10 days ago.

Status:Under Review Start date:2014-11-27
Priority:Should have Due date:
Assigned To:Anja Leichsenring % Done:

100%
Category:- Spent time: -
Target version:-
TYPO3 Version:6.2 Is Regression:No
PHP Version: Sprint Focus:
Complexity:

Description

Although documented inside the code and also on docs.typo3.org, the new properties layoutRootPaths and partialRootPaths both currently still miss stdWrap.

Add it!

(Nitpick: Also fix the comment in around line 39 to say "partialRootPaths array of filepaths+stdWrap Root paths to partials")

Related issues

related to Core - Bug #68416: Recently merged fix for FLUIDTEMPLATE: New fallback paths... New 2015-07-21
follows Core - Bug #61361: Fluid template path fallback doesn't work in TypoScript o... Resolved 2014-09-05

Associated revisions

Revision 3e4dbc39
Added by Frederic Gaus 7 months ago

[BUGFIX] Fix phpDoc of FluidTemplateContentObject::render

Change-Id: Ia91bac1ac2f26c500ce1fdc0d2eedece9ab30876
Resolves: #63380
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35809
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 76fe2491
Added by Frederic Gaus 7 months ago

[BUGFIX] Fix phpDoc of FluidTemplateContentObject::render

Change-Id: Ia91bac1ac2f26c500ce1fdc0d2eedece9ab30876
Resolves: #63380
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35816
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision f16a00ed
Added by Anja Leichsenring 16 days ago

[BUGFIX] Add stdWrap support for Partial- and layoutRootPaths

The single occurrences layoutRootPath and partialRootPath have
stdWrap support, but not the collection entries of
layoutRootPaths and partialRootPaths. This is added now.

Change-Id: I59d4967ce67b48b53e9bf1052d703c974f1472ca
Resolves: #63380
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/41584
Reviewed-by: Oliver Eglseder <>
Tested-by: Oliver Eglseder <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>

History

#1 Updated by Chris topher 8 months ago

  • Description updated (diff)

#2 Updated by Frederic Gaus 7 months ago

This is not true for the current master. For layoutRootPath the stdWrap is applied in line 132 and for partialRootPath the stdWrap is applied in line 156. So only the phpDoc has to be fixed.

#3 Updated by Gerrit Code Review 7 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35809

#5 Updated by Gerrit Code Review 7 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35809

#6 Updated by Gerrit Code Review 7 months ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35816

#7 Updated by Wouter Wolters 7 months ago

  • Status changed from Under Review to Resolved

#8 Updated by Chris topher 7 months ago

  • Status changed from Resolved to New

Frederic Gaus wrote:

For layoutRootPath the stdWrap is applied in line 132 and for partialRootPath the stdWrap is applied in line 156. So only the phpDoc has to be fixed.

Thanks for pushing the patch, guys! However, please double check the exact property names! You are speaking about the properties without plural -s. What I mean are different properties - I mean layoutRootPaths and partialRootPaths - those with plural -s at the end.

These two properties still miss stdWrap!

#9 Updated by Gerrit Code Review 17 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584

#10 Updated by Gerrit Code Review 17 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584

#11 Updated by Gerrit Code Review 17 days ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584

#12 Updated by Gerrit Code Review 17 days ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584

#13 Updated by Gerrit Code Review 17 days ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584

#14 Updated by Gerrit Code Review 17 days ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584

#15 Updated by Markus Sommer 17 days ago

  • Assigned To set to Anja Leichsenring

#16 Updated by Gerrit Code Review 16 days ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584

#17 Updated by Gerrit Code Review 16 days ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41584

#18 Updated by Anja Leichsenring 16 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#19 Updated by Gerrit Code Review 16 days ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41679

#20 Updated by Loek Hilgersom 16 days ago

Current solution as implemented and merged in http://review.typo3.org/41584 doesn't work correctly.

cObj->stdWrap calls should be replaced by cObj->cObjGetSingle

#21 Updated by Gerrit Code Review 12 days ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41820

#22 Updated by Gerrit Code Review 10 days ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41679

#23 Updated by Gerrit Code Review 10 days ago

Patch set 3 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41679

#24 Updated by Gerrit Code Review 10 days ago

Patch set 4 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41679

Also available in: Atom PDF