Bug #63733

Bug #63692: Memory consumption while bulk inserting

Do not call recordInfo() for new records in DataHandler->checkValue

Added by Stephan Großberndt 8 months ago. Updated 6 months ago.

Status:Resolved Start date:2014-12-10
Priority:Should have Due date:
Assigned To:- % Done:

100%
Category:Performance Spent time: -
Target version:next-patchlevel
TYPO3 Version:6.2 Is Regression:No
PHP Version: Sprint Focus:
Complexity:easy

Description

Currently DataHandler->checkValue calls

// Get current value:
$curValueRec = $this->recordInfo($table, $id, $field);
$curValue = $curValueRec[$field];

even for new records ($id = 'NEW...')

When bulk inserting 6500 records checking the id before calling recordInfo saves 5MB of RAM:

if (!(int)$id) {
    $curValue = NULL;
} else {
    // Get current value:
    $curValueRec = $this->recordInfo($table, $id, $field);
    $curValue = $curValueRec[$field];
}

Associated revisions

Revision 27842f72
Added by Stephan Großberndt 6 months ago

[BUGFIX] Avoid to call recordInfo for new records

Avoid to call recordInfo for new records in DataHandler->checkValue by
checking the id. This improves performance for bulk inserts.

Resolves: #63733
Releases: master, 6.2
Change-Id: I02c2d282f487defe3c74d89e7041ecb8b0eae7b8
Reviewed-on: http://review.typo3.org/35237
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Benjamin Mack <>
Tested-by: Benjamin Mack <>

Revision b783a951
Added by Stephan Großberndt 6 months ago

[BUGFIX] Avoid to call recordInfo for new records

Avoid to call recordInfo for new records in DataHandler->checkValue by
checking the id. This improves performance for bulk inserts.

Resolves: #63733
Releases: master, 6.2
Change-Id: I02c2d282f487defe3c74d89e7041ecb8b0eae7b8
Reviewed-on: http://review.typo3.org/36595
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35237

#2 Updated by Wouter Wolters 8 months ago

  • Parent task set to #63692

#3 Updated by Gerrit Code Review 8 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35237

#4 Updated by Gerrit Code Review 7 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35237

#5 Updated by Gerrit Code Review 7 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35237

#6 Updated by Gerrit Code Review 6 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35237

#7 Updated by Gerrit Code Review 6 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35237

#8 Updated by Gerrit Code Review 6 months ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36595

#9 Updated by Stephan Großberndt 6 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF