Bug #63778

Bug #63692: Memory consumption while bulk inserting

Do not fetch TSconfig in DataHandler->process_datamap for non-page-records

Added by Stephan Großberndt 8 months ago. Updated 8 months ago.

Status:Resolved Start date:2014-12-11
Priority:Should have Due date:
Assigned To:- % Done:

100%

Category:Performance Spent time: -
Target version:next-patchlevel
TYPO3 Version:6.2 Is Regression:No
PHP Version: Sprint Focus:
Complexity:no-brainer

Description

In DataHandler->process_datamap for each record DataHandler->getTCEMAIN_TSconfig is executed, but the TSconfig is used only if $status 'new' && $table 'pages'

if ($recordAccess) {
    // Here the "pid" is set IF NOT the old pid was a string pointing to a place in the subst-id array.
    list($tscPID) = BackendUtility::getTSCpid($table, $id, $old_pid_value ? $old_pid_value : $fieldArray['pid']);
    $TSConfig = $this->getTCEMAIN_TSconfig($tscPID);
    if ($status == 'new' && $table == 'pages' && is_array($TSConfig['permissions.'])) {
        $fieldArray = $this->setTSconfigPermissions($fieldArray, $TSConfig['permissions.']);
    }

Associated revisions

Revision 68806a35
Added by Stephan Großberndt 8 months ago

[BUGFIX] Do not fetch TSconfig in process_datamap for non-page-records

In DataHandler->process_datamap for each record getTCEMAIN_TSconfig()
is executed, but the returned TSconfig is used only if table is "pages"
and status is "new".

Fetches the TSconfig only if table is "pages" and status is "new".

Resolves: #63778
Releases: master, 6.2
Change-Id: Ifded6daf2b5b6b61a9c95ba3962566450a07d72e
Reviewed-on: http://review.typo3.org/35304
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Lukas Krieger <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

Revision 3a19c861
Added by Stephan Großberndt 8 months ago

[BUGFIX] Do not fetch TSconfig in process_datamap for non-page-records

In DataHandler->process_datamap for each record getTCEMAIN_TSconfig()
is executed, but the returned TSconfig is used only if table is "pages"
and status is "new".

Fetches the TSconfig only if table is "pages" and status is "new".

Resolves: #63778
Releases: master, 6.2
Change-Id: Ifded6daf2b5b6b61a9c95ba3962566450a07d72e
Reviewed-on: http://review.typo3.org/35318
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

History

#1 Updated by Alexander Opitz 8 months ago

  • Parent task set to #63692

#2 Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35304

#3 Updated by Gerrit Code Review 8 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35304

#4 Updated by Gerrit Code Review 8 months ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35318

#5 Updated by Stephan Großberndt 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF