Bug #63784

Bug #63692: Memory consumption while bulk inserting

Do not check for generated key in possibly empty array in DataHandler->fillInFieldArray

Added by Stephan Großberndt 8 months ago. Updated 5 months ago.

Status:Resolved Start date:2014-12-11
Priority:Should have Due date:
Assigned To:Stephan Großberndt % Done:

100%
Category:Performance Spent time: -
Target version:next-patchlevel
TYPO3 Version:6.2 Is Regression:No
PHP Version: Sprint Focus:
Complexity:no-brainer

Description

If $this->exclude_array is empty its not necessary to check for the existence.

foreach ($incomingFieldArray as $field => $fieldValue) {
    if (!in_array(($table . '-' . $field), $this->exclude_array) && !$this->data_disableFields[$table][$id][$field]) {

Associated revisions

Revision 3b6a0912
Added by Stephan Großberndt 5 months ago

[!!!][TASK] Replace DataHandler->exclude_array with key-based array

Replace the public property array 'exclude_array' in DataHandler with a
protected property 'excludedTablesAndFields' using keys instead of
values. This change improves performance for bulk inserts since in
DataHandler->fillInFieldArray() many in_array()-checks can be avoided.

Resolves: #63784
Releases: master
Change-Id: I478319fea022c3eceaac35da9c093d1c43ecb2e4
Reviewed-on: http://review.typo3.org/35315
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

#2 Updated by Gerrit Code Review 8 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

#3 Updated by Gerrit Code Review 8 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

#4 Updated by Mathias Schreiber 8 months ago

  • Parent task set to #63692

#5 Updated by Gerrit Code Review 8 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

#6 Updated by Gerrit Code Review 8 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

#7 Updated by Gerrit Code Review 8 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

#8 Updated by Gerrit Code Review 7 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

#9 Updated by Gerrit Code Review 5 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

#10 Updated by Gerrit Code Review 5 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

#11 Updated by Gerrit Code Review 5 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

#12 Updated by Stephan Großberndt 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF