Bug #64916
Avoid serialization of some members of ContentObjectRenderer
| Status: | Resolved | Start date: | 2015-02-06 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Markus Klein | % Done: | 100% |
|
| Category: | Backend API | Spent time: | - | |
| Target version: | 7.1 (Cleanup) | |||
| TYPO3 Version: | 7 | Is Regression: | No | |
| PHP Version: | Sprint Focus: | Stabilization Sprint | ||
| Complexity: | hard |
Description
UserInternalContentObject is trying to serialize ContentObjectRenderer.
This leads to severe issues also uses lots of memory.
If you set up a page like this
page = PAGE page.10 < styles.content.get page.20 < plugin.tx_felogin_pi1
Install sysext:felogin and add static templates for CSC and felogin!
Add a "text w/image" CE to the page and add at least one image.
you'll get an Exception in FE: Serialization of closure not possible.
(In order to see the Exception you need to set the application context to Development and select the Development-preset in Install Tool.)
The reason is that if the Core is not installed via composer, a closure is registered in the SignalSlotDispatcher.
For some reason, when serializing ContentObjectRenderer, also SignalSlotDispatcher is serialized, which leads to this exception.
The solution is to remove the "hard-wires" between ContentObjectRenderer and TSFE and File(Reference).
Related issues
Associated revisions
[BUGFIX] Exclude some vars from serialization
This voids the serialization of TSFE and currentFile with the
ContentObjectRenderer in UserInternalContentObject.
Releases: master
Resolves: #64916
Change-Id: I2ce74ee0960d33b39dec51c2f6150d79a113d5fe
Reviewed-on: http://review.typo3.org/36723
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
History
#1 Updated by Gerrit Code Review 6 months ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36723
#2 Updated by Gerrit Code Review 6 months ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36723
#3 Updated by Markus Klein 6 months ago
- Description updated (diff)
#4 Updated by Gerrit Code Review 6 months ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36723
#5 Updated by Gerrit Code Review 6 months ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36723
#6 Updated by Markus Klein 6 months ago
- Subject changed from Avoid serialization of TSFE with ContentObjectRenderer to Avoid serialization of some members of ContentObjectRenderer
- Description updated (diff)
#7 Updated by Markus Klein 6 months ago
- Description updated (diff)
#8 Updated by Helmut Hummel 6 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 4bbdf7725b06ce2ed89d95217b6371ec40a0667a.