Bug #65239
Missing (string) cast or isset() check in HTMLparser
| Status: | Resolved | Start date: | 2015-02-23 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Markus Klein | % Done: | 100% |
|
| Category: | Backend API | Spent time: | - | |
| Target version: | next-patchlevel | |||
| TYPO3 Version: | 7 | Is Regression: | Yes | |
| PHP Version: | Sprint Focus: | |||
| Complexity: | no-brainer |
Description
#54091 introduced a regression with a missing (string) cast or isset() check.
If fixAttrib.set is not set, it is !== '' and therefore overwrites every value.
Related issues
Associated revisions
[BUGFIX] Add missing isset() check in HTMLParser
This is a regression fix for #54091.
It has been forgotten to add an isset() check for 'fixAttrib.set'.
Releases: master
Resolves: #65239
Change-Id: Ia39ef0760dab61bdb5bbfb71e525cc96e15f3077
Reviewed-on: http://review.typo3.org/37115
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
History
#1 Updated by Gerrit Code Review 5 months ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37115
#2 Updated by Markus Klein 5 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 6bfed6130f1cb8ede8f8174c3b4543b3606f782e.