Bug #65319
Epic #65314: PHP7
ResourceUtilityTest::recursiveFileListSortingHelperCorrectlySorts
| Status: | Resolved | Start date: | 2015-02-25 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Alexander Opitz | % Done: | 100% |
|
| Category: | - | Spent time: | - | |
| Target version: | 7 LTS | |||
| TYPO3 Version: | 6.2 | Is Regression: | No | |
| PHP Version: | 7.0 | Sprint Focus: | ||
| Complexity: |
Description
TYPO3\CMS\Core\Tests\Unit\Utility\ResourceUtilityTest::recursiveFileListSortingHelperCorrectlySorts with data set "mixed capitalization" (array('alllower', 'allCAPS', 'ALLcaps', 'mIxedinanotherway', 'ALLCAPS', 'MiXeDcApItAlIzAtIoN'), array('ALLCAPS', 'ALLcaps', 'allCAPS', 'alllower', 'MiXeDcApItAlIzAtIoN', 'mIxedinanotherway'))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
- 0 => 'ALLCAPS'
+ 0 => 'allCAPS'
1 => 'ALLcaps'
- 2 => 'allCAPS'
+ 2 => 'ALLCAPS'
3 => 'alllower'
4 => 'MiXeDcApItAlIzAtIoN'
5 => 'mIxedinanotherway'
)
/home/opitz/projects/typo3-master/typo3-src/typo3/sysext/core/Tests/Unit/Utility/ResourceUtilityTest.php:68
/home/opitz/projects/neos-git/Packages/Libraries/phpunit/phpunit/phpunit7:56
=> unatcasesort, internally same issue on swap?
=> Open an issue in PHP issue tracker
=> Also in HHVM
Related issues
Associated revisions
[BUGFIX] Fix FileList ordering for upper/lowercase
File names which only differ in upper/lowercase writing are now sorted
stable with uppercase first.
Resolves: #65319
Releases: master, 6.2
Change-Id: Ib1b907cb8aed6364aadc4f028cfc9294b5c18884
Reviewed-on: http://review.typo3.org/37250
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
[BUGFIX] Fix FileList ordering for upper/lowercase
File names which only differ in upper/lowercase writing are now sorted
stable with uppercase first.
Resolves: #65319
Releases: master, 6.2
Change-Id: Ib1b907cb8aed6364aadc4f028cfc9294b5c18884
Reviewed-on: http://review.typo3.org/39967
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
History
#1 Updated by Alexander Opitz 5 months ago
- Description updated (diff)
#2 Updated by Alexander Opitz 5 months ago
This seams no issue in PHP. It is an issue of the functionality or the test.
#3 Updated by Alexander Opitz 5 months ago
- Description updated (diff)
#4 Updated by Alexander Opitz 5 months ago
After deeper looking in the cause of this issue, it is a bug in our implementation.
Fixes issue with PHP7 and HHVM.
#5 Updated by Gerrit Code Review 5 months ago
- Status changed from New to Under Review
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37250
#6 Updated by Gerrit Code Review 4 months ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37250
#7 Updated by Gerrit Code Review 3 months ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37250
#8 Updated by Gerrit Code Review 2 months ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37250
#9 Updated by Gerrit Code Review 2 months ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37250
#10 Updated by Gerrit Code Review 2 months ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37250
#11 Updated by Alexander Opitz 2 months ago
- Assigned To set to Alexander Opitz
- % Done changed from 0 to 50
#12 Updated by Gerrit Code Review about 1 month ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39967
#13 Updated by Alexander Opitz about 1 month ago
- Status changed from Under Review to Resolved
- % Done changed from 50 to 100
Applied in changeset 773e80e67b1ef8882b80b6f19129a8c3e2835183.