Bug #65320
Epic #65314: PHP7
BooleanNodeTest::convertToBooleanProperlyConvertsNumericValues
| Status: | Resolved | Start date: | 2015-02-25 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | - | % Done: | 100% |
|
| Category: | - | Spent time: | - | |
| Target version: | 7 LTS | |||
| TYPO3 Version: | 6.2 | Is Regression: | No | |
| PHP Version: | 7.0 | Sprint Focus: | ||
| Complexity: |
Description
TYPO3\CMS\Fluid\Tests\Unit\Core\Parser\SyntaxTree\BooleanNodeTest::convertToBooleanProperlyConvertsNumericValues
Failed asserting that true is false.
/home/opitz/projects/typo3-master/typo3-src/typo3/sysext/fluid/Tests/Unit/Core/Parser/SyntaxTree/BooleanNodeTest.php:422
/home/opitz/projects/neos-git/Packages/Libraries/phpunit/phpunit/phpunit7:56
=> is_numeric handling changed for string, is_numeric('0x0') with 5.x TRUE, with 7.0 FALSE
=> Only change test or has this any relevance elsewhere?
Associated revisions
[TASK] PHP7 is_numeric change
With PHP 7 the string 0x0 isn't any longer a numeric, so the test
fails. But the test itself makes no sense and is removed.
Resolves: #65320
Releases: master, 6.2
Change-Id: Id7569dfb859ecee7c85c595640515781b1423614
Reviewed-on: http://review.typo3.org/39745
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
[TASK] PHP7 is_numeric change
With PHP 7 the string 0x0 isn't any longer a numeric, so the test
fails. But the test itself makes no sense and is removed.
Resolves: #65320
Releases: master, 6.2
Change-Id: Id7569dfb859ecee7c85c595640515781b1423614
Reviewed-on: http://review.typo3.org/39782
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
History
#1 Updated by Gerrit Code Review 2 months ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39745
#2 Updated by Gerrit Code Review 2 months ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39745
#3 Updated by Gerrit Code Review 2 months ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39782
#4 Updated by Alexander Opitz 2 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 07b02d762ee518e595f2e0ecb5f2cbbfd92cfc2f.