Bug #67138

Missing (int) cast in \TYPO3\CMS\Backend\Tree\Pagetree\Commands

Added by Markus Klein 2 months ago. Updated 2 months ago.

Status:Resolved Start date:2015-05-26
Priority:Should have Due date:
Assigned To:Markus Klein % Done:

100%
Category:- Spent time: -
Target version:-
TYPO3 Version:6.2 Is Regression:No
PHP Version: Sprint Focus:
Complexity:no-brainer

Description

if ($record['uid'] !== 0) {

fails to ensure the uid is really an int. Since $record stems from DB, its elements are strings.

Associated revisions

Revision 7c8bc63d
Added by Markus Klein 2 months ago

[BUGFIX] Add missing int-cast for checking uid zero

The change #24250 introduced a strict comparison without ensuring
proper data types on both sides of the comparison.

Add the missing int-cast in \TYPO3\CMS\Backend\Tree\Pagetree\Commands

Resolves: #67138
Releases: master,6.2
Change-Id: I51dc33fd64a6d42963237ac49e0385c2abf66b71
Reviewed-on: http://review.typo3.org/39727
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision aed83b7d
Added by Markus Klein 2 months ago

[BUGFIX] Add missing int-cast for checking uid zero

The change #24250 introduced a strict comparison without ensuring
proper data types on both sides of the comparison.

Add the missing int-cast in \TYPO3\CMS\Backend\Tree\Pagetree\Commands

Resolves: #67138
Releases: master,6.2
Change-Id: I51dc33fd64a6d42963237ac49e0385c2abf66b71
Reviewed-on: http://review.typo3.org/39729
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Gerrit Code Review 2 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39727

#2 Updated by Gerrit Code Review 2 months ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39729

#3 Updated by Markus Klein 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF