Bug #67189
Epic #65314: PHP7
LogRecordTest::toStringIncludesExceptionDataAsJson
Status: | Resolved | Start date: | 2015-05-29 | |
---|---|---|---|---|
Priority: | Should have | Due date: | ||
Assigned To: | Alexander Opitz | % Done: | 100% |
|
Category: | - | Spent time: | - | |
Target version: | 7 LTS | |||
TYPO3 Version: | 6.2 | Is Regression: | No | |
PHP Version: | 7.0 | Sprint Focus: | ||
Complexity: |
Description
Failed asserting that 'Fri, 29 May 2015 08:44:59 +0000 [DEBUG] request="e499f6eb7846b" component="test.core.log": test message - {"exception":"Exception: foo in /typo3-src/typo3/sysext/core/Tests/Unit/Log/LogRecordTest.php:158 Stack trace: #0 [internal function]: TYPO3\\CMS\\Core\\Tests\\Unit\\Log\\LogRecordTest->toStringIncludesExceptionDataAsJson() #1 /phpunit/phpunit/src/Framework/TestCase.php(865): ReflectionMethod->invokeArgs(Object(TYPO3\\CMS\\Core\\Tests\\Unit\\Log\\LogRecordTest), Array) #2 /phpunit/phpunit/src/Framework/TestCase.php(743): PHPUnit_Framework_TestCase->runTest() #3 /phpunit/phpunit/src/Framework/TestResult.php(609): PHPUnit_Framework_TestCase->runBare() #4 /phpunit/phpunit/src/Framework/TestCase.php(699): PHPUnit_Framework_TestResult->run(Object(TYPO3\\CMS\\Core\\Tests\\Unit\\Log\\LogRecordTest)) #5 /phpunit/phpunit/src/Framework/TestSuite.php(722): PHPUnit_Framework_TestCase->run(Object(PHPUnit_Framework_TestResult)) #6 /phpunit/phpunit/src/Framework/TestSuite.php(722): PHPUnit_Framework_TestSuite->run(Object(PHPUnit_Framework_TestResult)) #7 /phpunit/phpunit/src/Framework/TestSuite.php(722): PHPUnit_Framework_TestSuite->run(Object(PHPUnit_Framework_TestResult)) #8 /phpunit/phpunit/src/TextUI/TestRunner.php(406): PHPUnit_Framework_TestSuite->run(Object(PHPUnit_Framework_TestResult)) #9 /phpunit/phpunit/src/TextUI/Command.php(153): PHPUnit_TextUI_TestRunner->doRun(Object(PHPUnit_Framework_TestSuite), Array) #10 /phpunit/phpunit/src/TextUI/Command.php(105): PHPUnit_TextUI_Command->run(Array, true) #11 /phpunit/phpunit/phpunit7(56): PHPUnit_TextUI_Command::main() #12 {main}"}' contains "'Exception' with message 'foo'"
=> PHP changed format of Exception Messages
=> https://github.com/php/php-src/pull/1226
Associated revisions
[TASK] Adjust Log tests for changed exception format in PHP7
https://github.com/php/php-src/commit/3ae995f03c8f60c4a4c9718262545cf5a6a08da3
Resolves: #67189
Releases: master, 6.2
Change-Id: Icc94ebb403d963b6cdb367df8e7a590c581e940c
Reviewed-on: http://review.typo3.org/39859
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
[TASK] Adjust Log tests for changed exception format in PHP7
https://github.com/php/php-src/commit/3ae995f03c8f60c4a4c9718262545cf5a6a08da3
Resolves: #67189
Releases: master, 6.2
Change-Id: Icc94ebb403d963b6cdb367df8e7a590c581e940c
Reviewed-on: http://review.typo3.org/39978
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
History
#1 Updated by Alexander Opitz 2 months ago
- Description updated (diff)
#2 Updated by Alexander Opitz 2 months ago
- Parent task set to #65314
#3 Updated by Gerrit Code Review 2 months ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39859
#4 Updated by Gerrit Code Review 2 months ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39859
#5 Updated by Alexander Opitz 2 months ago
- Status changed from Under Review to Accepted
- Assigned To set to Alexander Opitz
- % Done changed from 0 to 50
#6 Updated by Gerrit Code Review about 1 month ago
- Status changed from Accepted to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39978
#7 Updated by Alexander Opitz about 1 month ago
- Status changed from Under Review to Resolved
- % Done changed from 50 to 100
Applied in changeset eb6bec53e25020c173a9a7fb8cc48c333d24ce85.