Task #6727
Refactor the ConjunctionValidator and DisjunctionValidator
| Status: | Resolved | Start date: | 2010-03-15 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Karsten Dambekalns | % Done: | 100% |
|
| Category: | Validation | |||
| Target version: | TYPO3 Flow Base Distribution - 1.0 alpha 8 | Estimated time: | 1.00 hour | |
| Sprint: | Has patch: | |||
| PHP Version: | Complexity: |
Description
Hi,
I changed some comments in the DisjunctionValidator which where copied from the ConjunctionValidator without adapting. I also simplified both validators not needing anymore a variable $result.
Lukas
ConjunctionValidator.diff
(597 Bytes)
DisjunctionValidator.diff
(1.4 kB)
Associated revisions
[~TASK] FLOW3 (Validation): Some documentation cleanup to DisjunctionValidator, resolves #6727.
History
#1 Updated by Lukas Lentner over 5 years ago
- File ConjunctionValidator.diff added
- File DisjunctionValidator.diff added
The diffs where made in Windows! (Tabs wrong and so on ...)
Here the proper Linux version
#2 Updated by Karsten Dambekalns over 5 years ago
- File deleted (
ConjunctionValidator.diff)
#3 Updated by Karsten Dambekalns over 5 years ago
- File deleted (
DisjunctionValidator.diff)
#4 Updated by Karsten Dambekalns over 5 years ago
- Status changed from New to Accepted
- Assigned To set to Karsten Dambekalns
- Target version set to 1.0 alpha 8
- Start date changed from 2010-03-07 to 2010-03-15
- Estimated time set to 1.00
#5 Updated by Karsten Dambekalns over 5 years ago
Lukas Lentner wrote:
I also simplified both validators not needing anymore a variable $result.
And thus not including all possible errors anymore. See, the result isn't changed after the first FALSE, but there could be more errors being appended... :)
#6 Updated by Karsten Dambekalns over 5 years ago
- Status changed from Accepted to Resolved
- % Done changed from 50 to 100
Applied in changeset r3949.
#7 Updated by Lukas Lentner over 5 years ago
I'm sorry. I didn't see this possibillity ;-(