TYPO3.Fluid

note to myself: we need proper selenium tests for the if ViewHelper.

After thinking about this right now, I think this could actually work. I always thought that the above clashes with the object accessor syntax like {..}, but as they are clearly identified by the braces, there should not be any problem.

So, after proper testing and test coverage, I think this could work out.

Greets,
Sebastian

+1 for implementing that from me. I would like string literals surrounded by single quotes better.

+1, I am amazed this isn't possible: <f:if condition="{foo} !== 'bar'"><f:then> ...

I just took the initial idea further and required string literals to be written in single quotes.
This is necessary for allowing white spaces in the strings.
I also added basic unit tests for this behaviour and all other unit tests still pass.
It also works nicely in an extbase project so far, but a functional test probably won't hurt, I just couldn't get functional tests running in Zend Studio yet.

However there are still some questions that I'd like feedback on:

1) Should double quotes also be allowed? IMO it's probably problematic anyway, since boolean expressions are mostly used in viewhelper attributes, which are (double) quoted normally, so the double quotes would have to be escaped. On the other hand, it is standard behaviour to be able to quote with both single and double quotes in most programming languages.

2) What about comparison of string literals against constant numbers? Since the numbers are parsed as string numerics, the comparator compares two strings which will never be equal unless you compare for example '5' == 5.
Also 'string' == 0 will resolve to TRUE in PHP, while with the current solution this will resolve to FALSE, so this might be unexpected behaviour.
This could be solved by casting unquoted numerics to float/int, but I'm not sure how it would work for comparison with variables holding numbers.

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13421

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13421

Ok, so after quite some fiddling with this and the Viewhelpertest package, I come to the following conclusions:

1) proper string -> number comparison is definitely a must have, since else the boolean node behaves differently when comparing a string to a constant number than comparing a string to variable with a constant number value, ie.
('foo' == 1) !== ('foo' == {constantOne})
and this is a no-go IMO (and also leads to un-green-able Viewhelpertest).

2) adding string -> number comparison is not simply achieved by casting the text node, as the input must always be cast on evaluation (text nodes may only be created from strings), but there the distinguishing information of numeric string ("{'foo' == '0'}") or numeric literal ("{'foo' == 0}") is lost, since quotes are stripped beforehand in the boolean node.
Hence, the introduction of a NumericNode (or NumberNode?) is needed.

I will push a changeset shortly.

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13421

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13421

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13421

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13554

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13555

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13421