Task #67593
Epic #58498: Cleanup FormEngine suggest
Split up Suggest AJAX method
| Status: | Resolved | Start date: | 2015-06-18 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Andreas Wolf | % Done: | 100% |
|
| Category: | FormEngine aka TCEforms | Spent time: | - | |
| Target version: | 7.4 (Backend) | |||
| TYPO3 Version: | 7 | Complexity: | ||
| PHP Version: | Sprint Focus: |
Description
The AJAX method of Suggest is really long and does a multitude of things it should not do itself. Therefore split up the method and move stuff to helper methods, making the method easier to understand.
Associated revisions
[CLEANUP] FormEngine suggest: Split up AJAX method
This moves parts of the very complex AJAX receiver method to their own
methods, making the original method a lot shorter and easier to
understand.
Resolves: #67593
Releases: master
Change-Id: I2422313e988195c3c12ac9133542f1f6183cc5a4
Reviewed-on: http://review.typo3.org/40422
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
History
#1 Updated by Gerrit Code Review about 1 month ago
- Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40422
#2 Updated by Gerrit Code Review about 1 month ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40422
#3 Updated by Gerrit Code Review 20 days ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40422
#4 Updated by Gerrit Code Review 20 days ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40422
#5 Updated by Gerrit Code Review 20 days ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40422
#6 Updated by Gerrit Code Review 20 days ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40422
#7 Updated by Andreas Wolf 20 days ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 56fd448d350acc59a2cc268dbdb9905ffcd2033e.