Bug #68562
Epic #68397: Make TYPO3 work with MySQL strict mode
Bool values need to be cast to integer for MySQL strict mode
| Status: | New | Start date: | 2015-07-27 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Morton Jonuschat | % Done: | 100% |
|
| Category: | Database API | Spent time: | - | |
| Target version: | 7 LTS | |||
| TYPO3 Version: | 7 | Is Regression: | No | |
| PHP Version: | 5.6 | Sprint Focus: | ||
| Complexity: |
Description
MySQL strict mode doesn't accept '' as a valid value to store in an integer column if the MySQL is run in strict mode.
Boolean values are cast by mysqli_real_escape string to '1' (for TRUE) and '' (for FALSE). Due to this special handling is required for boolean values to result in '0' and '1' for FALSE/TRUE
Related issues
Associated revisions
[BUGFIX] Database API: Cast bool values to integer for MySQL
Convert boolean values to integers before processing them with
mysqli_real_escape_string() to ensure that FALSE values get converted to
'0' instead of '', which isn't a valid value for integer columns in
MySQL strict mode.
Resolves: #68562
Releases: master
Change-Id: I974ebe6bc82ab54d2dd89a792536b0401eb1c81e
Reviewed-on: http://review.typo3.org/41993
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
History
#1 Updated by Morton Jonuschat 7 days ago
- Status changed from New to In Progress
#2 Updated by Gerrit Code Review 7 days ago
- Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41993
#3 Updated by Morton Jonuschat 6 days ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset cc72fd7e874c44bbd6ff6dd17c0b3ef6cdfb3623.
#4 Updated by Christian Kuhn 6 days ago
- Status changed from Resolved to New
patch was unfortunately reverted with https://review.typo3.org/#/c/42076/
#5 Updated by Morton Jonuschat 6 days ago
After discussion with Stefan Neufeind the initial implementation is still the best way to go, but the bug(s) in EXT:impexp need to be fixed first. Additionally this should be marked as breaking to be on the safe side.
#6 Updated by Marc Bastian Heinrichs about 16 hours ago
Link to the failing tests https://travis-ci.org/TYPO3/TYPO3.CMS/jobs/73080775