TYPO3.Fluid

Sebastian Kurfuerst wrote:

So, to fix this, we'd need to store the real action name back into the request.

Maybe the router should already check, whether the specified action really exists (and use the next route if it doesn't). Then we could already put the correctly camelcased action name into the request object.
I just don't know if a) we need this, b) this isn't a potential bottleneck

Additionally, you are now using UpperCamelCase for the filenames -- which I think is totally inconsistent and counter-intuitive.

I agree to use lowerCamelCase here

Hey,

Maybe the router should already check, whether the specified action really exists (and use the next route if it doesn't). Then we could already put the correctly camelcased action name into the request object.

Mhm, but the router does not know which action really exists...

I just don't know if a) we need this, b) this isn't a potential bottleneck

Yep. So I'd suggest right now, to do it pragmatically, and update the action name in the request.

Greets,
Sebastian

Robert Lemke wrote:

Hi folks,

yes you're right, I completely messed it up - the unit test works but that's, as you've seen - only half of the story.

I guess we'll go for Bastian's proposal and let the Router already check if an action exists. Currently a route which refers to a specific action would even match if such an action method does not exist - another bad behavior we could solve with this. So in the end the Request will contain a correctly cased action name.

Good idea!

As for the file naming conventions - I know that's a tough decision (well, most people don't think so, of course;-). After thinking about it again and again I think that 1 rule for all is more attractive and intuitive. So, let's go for that - all filenames and directory names are upper camel case.

Hmm, ok... I still see that somehow problematic / error-prone. I'm not sure yet how we can easily communicate that the Action names are normally lowerCamelCase, but in the file system, the corresponding templates are UpperCamelCase -- to me, this sounds a bit weird.
However, I could live with it, but as it's quite a severe change in terms of backwards compatibility, Fluid should throw an exception if it detects another capitalization in the directory than the UpperCamelCased version it expects (in Development mode).

For TYPO3 v4, I would not change this behavior right now, but I'd suggest to use a file no matter what the capitalization is -- We cannot introduce such a heavily breaking change without backwards compatibility anymore. (Yep, that's the price of all that backporting ;) )

Greets,
Sebastian

Hey,

I've again thought about this issue, and I still feel that a not-so-strict rule for file names would be better. For the following reason:
A file is an artifact which in FLOW3 often relates to some more abstract concept. For example, a .php file in the Classes/ folder actually is a PHP Class, and that's why the naming conventions for these classes apply in this part of the directory structure.
For actions, I think it is the same. The primary artifact is the action name, and this one is lowerCamelCase (as it is the method name in the ActionController). That's why the file which represents this artifact should have the same casing --> lowerCamelCase.

Sorry to discuss so much about that -- but I'd be interested how you'd explain a new user that actions in the file system are differently written than actions in the ActionController? (i.e., how to explain this in terms of Consistency?)

Greets,
Sebastian

Sebastian Kurfuerst wrote:

Hey,

I've again thought about this issue, and I still feel that a not-so-strict rule for file names would be better. For the following reason:
A file is an artifact which in FLOW3 often relates to some more abstract concept. For example, a .php file in the Classes/ folder actually is a PHP Class, and that's why the naming conventions for these classes apply in this part of the directory structure.
For actions, I think it is the same. The primary artifact is the action name, and this one is lowerCamelCase (as it is the method name in the ActionController). That's why the file which represents this artifact should have the same casing --> lowerCamelCase.

Sorry to discuss so much about that -- but I'd be interested how you'd explain a new user that actions in the file system are differently written than actions in the ActionController? (i.e., how to explain this in terms of Consistency?)

Greets,
Sebastian

Too me it seems both have their pros and cons, none is better. Both are Rules ("It's lowerCamelCase because of the method name in the ActionController" or "All dirs and files are UpperCamelCase") that have to be remembered, for some this is easier to remember for others that. And if I am a FLOW3/Fluid/Extbase dev I should know such rules anyway. Maybe the only point would be that "All dirs and files are UpperCamelCase" is a good naming scheme globally. For non devs both rules are not so intuitive (again a slight + for UpperCamelCase because it is not bound to know the PHP code) and template filenames should be configurable at some point anyway so that I can have a totally different (cased) name for my template (because it might make recognizing the template easier for my HTML guys...).

Christian

A file is an artifact which in FLOW3 often relates to some more abstract concept. For example, a .php file in the Classes/ folder actually is a PHP Class, and that's why the naming conventions for these classes apply in this part of the directory structure.
For actions, I think it is the same. The primary artifact is the action name, and this one is lowerCamelCase (as it is the method name in the ActionController). That's why the file which represents this artifact should have the same casing --> lowerCamelCase.

The problem with this rule is that you have to know how the case of the artifact is - what about locales? Or images? Stylesheets? You don't have to think about it if you have the one-rules-them-all-rule.

Too me it seems both have their pros and cons, none is better. Both are Rules ("It's lowerCamelCase because of the method name in the ActionController" or "All dirs and files are UpperCamelCase") that have to be remembered, for some this is easier to remember for others that. And if I am a FLOW3/Fluid/Extbase dev I should know such rules anyway. Maybe the only point would be that "All dirs and files are UpperCamelCase" is a good naming scheme globally. For non devs both rules are not so intuitive (again a slight + for UpperCamelCase because it is not bound to know the PHP code) and template filenames should be configurable at some point anyway so that I can have a totally different (cased) name for my template (because it might make recognizing the template easier for my HTML guys...).

Yes, and you can already do that by specifying your own custom template path and filename.