TYPO3.Neos

I'd like to have a look at this task and work on it.

Hey Michael,

I just wanted to ask what the current status on this issue is. Do you have any open questions, or is there anything we can do to support you solving this issue? You'll find us in the usual Jabber chatroom.

Thanks in advance for a short status!

Greets,
Sebastian

Hi Sebastian,

I am working on that actually! But it is not as that easy as it sounds. The main Task is a refactoring of the UI.ModuleMenu which holds for example the PageProperties Dialog. The ModuleMenu needs a better layout so that the ModuleDialog can be added as collapsible Panel to animate it. Furthermore the ContentDialog needs to be somehow better connected in the ModuleMenu so that it's height (and padding from the rootline) is automatically determined by the layout. This does not work yet.

But I'm on it :)

cheers

Hey,

I finally had some time to look at your patch. First of all, I think it really improves things quite a bit :-)

Michael Feinbier wrote:

so finally I can provide a little patch of some changes :)

The bad thing first. I think it is not possible to animate the ModuleDialogContainer when it get's shown for example as a collapsible panel. This is because the ModuleDialog wraps around it so that it is not connected to the ContentArea which needs to be animated. To make the animation work the ModuleDialogContainer and the ContentArea have to be part of the same border layout (mdc as north panel, content area as center panel). But this would mean some basic restructuring of the whole container concept. Let's talk about that later.

OK; we need to discuss how we can make this animation work nevertheless ;-) Triggering "doLayout" everytime should work, but I guess that's too expensive. What do you think about the following:

1. calculate the height of the form
2. animate the height of F3.TYPO3.UserInterface.ModuleMenu to the correct height

The ModuleMenu is on the same level as the ContentArea, so then animation should work, right?

What is done?

• refactoring of the whole showModuleDialog of the ModuleMenu: the DOM coupling of the contentDialog was removed and replaced by the add-method of the parent layout container.

nice!

• changing the layouts in SectionMenu, ModuleMenu and ModuleDialog from vbox to better layout managers

Great! From your patch it seems that you also changed "ModuleDialogContainer" to "form" layout; Does this have any special reason, or is it just a left-over? :-)

• loading of the form in PagePropertiesDialog is moved to an own method of the dialog. It is called once afterRender instead of onRender

This leads to the following improvements:

• The whole ModuleMenu and -Dialog is able to determine it's dimensions automatically. The ModuleMenu changes its height dynamically. Neither in the ModuleMenu nor in the PagePropertiesDialog (and in all ModuleDialogs) you need to set a height. Everything is done by the LayoutManager. Only the initial ModuleMenu needs a start height (50px - this can be improved, too)

Nice, this is already quite some improvement.

...

Known Problems:

• I did not make it work to lay the content dialog buttons over the content-area via CSS. I think it can be done by CSS - the content dialog container is added to the parent in the same way as before (but via .add()). I think/hope that this is a small thing for a CSS-Guru.

In fact it's not that easy. As the content dialog buttons are added to the ContentDialog now, it will not display these buttons anymore because ExtJS uses "overflow:hidden" for the parent containers. That's why I'd suggest to add the buttons to the F3.TYPO3.UserInterface.ContentArea, as it was before.

• When the ModuleMenuContainer expands, the content area get's an additional vertical scrollbar which isn't needed. I am working on that.

Interesting, which browser are you using? Here, this works without another scrollbar.

Thanks for the time you are devoting to v5, it's really encouraging to see your work!

Greets,
Sebastian

Hey,

great news :-) I'm really looking forward to it!

Greets,
Sebastian

Hi,

is there anything I can do for this issiue?
I am waiting for any response :)

Hey,
I think that this is not relevant for this task ;-) As it is not about the Accordion Menu ;)

Ah, one more note: We're using the IRC channel "t3px" at irc.freenode.net
Greets,
Sebastian

I just tried it out, and it seems quite hard; that's why I suggest to wait for ExtJS 4 and see if this helps for us :-)

Greets,
Sebastian