TYPO3.Neos

Ok, wasn't as easy as I thought.

First thing is the person argument, it won't validate if the name fields are not set and as I didn't find any (easy) way to intercept the validation error and give something nice instead, I set @dontvalidate and check it myself. The person requires a name to validate (which I don't like) so I check if at least one of the two fields is set. Finally that means that you need to fill at least three fields.

At least for me the current redirect in SVN version with: $this->redirect('index', 'Frontend\Page');
didn't work at all, so I changed to a (more dirty) but working: $this->redirectToUri('');

You can at maximum get two "error/info" messages:

• To create the administrator account you must enter an username and a password.
• Please provide at least first name or last name for the administrator account.

Both messages are to be found in F3\TYPO3\Controller\Backend\SetupController->importAndCreateAdministratorAction()

They are output as flashMessage and styled by the inline styles (no stylsheet included and already some inline styles...) in Setup Layout.

A screenhot especially for Berit... Here are both messages you can get in FF 3.6

Styles are found in: trunk\Packages\Application\TYPO3\Resources\Private\Layouts\Setup.html
I added some for the messages in my patch.

Hey Christian,

thanks for working on this issue.

First thing is the person argument, it won't validate if the name fields are not set and as I didn't find any (easy) way to intercept the validation error and give something nice instead, I set @dontvalidate and check it myself. The person requires a name to validate (which I don't like) so I check if at least one of the two fields is set. Finally that means that you need to fill at least three fields.

for the createAdministrator() method, you do not need @dontvalidate annotations, as it is not an action.

At least for me the current redirect in SVN version with: $this->redirect('index', 'Frontend\Page');
didn't work at all, so I changed to a (more dirty) but working: $this->redirectToUri('');

This needs to be changed back, and we need to investigate the real error for this. $this->redirectToUri() can also break, specifically if you run TYPO3 in a subfolder.

Could you please provide information what your URI to the setup controller is, and the URI which is being redirected to?

You can at maximum get two "error/info" messages:

• To create the administrator account you must enter an username and a password.
• Please provide at least first name or last name for the administrator account.

Very nice.

In general, the solution with the "@dontvalidate" annotation and doing the validation yourself feels a bit hacky, but as long as the error messaging system is still not good, I think it's a good workaround.

Thanks again for working on this issue!

Greets,
Sebastian

Christian, thank you for your work!

After trying it out and looking through the remaining code of the SetupController I decided to clean it up a little. I'm afraid that your patch is a bit too hacky as it circumvents the FLOW3 validation mechanism.

I just committed an implementation which does use the FLOW3 API for displaying validation errors - it's not really polished but it's basically working.

During the next sprint we'll have to clean this up more thoroughly and also discuss possible improvements for the MVC error handling and validation messages.