Fluid - ViewHelper - Incubator

1. Class is Tx_Hype_ViewHelpers_Format_FilesizeViewHelper should be Tx_ViewhelperIncubator_ViewHelpers_Format_FilesizeViewHelper
2. A v5 version is missing (just replace Tx_..._... by \F3\...\...
3. Unit tests are missing

Furthermore one or two examples in the source code (above the class declaration) would be good. Like:

 * [...]
 * = Examples =
 *
 * 
 * <f:format.filesize size="123456" />
 * 
 *
 * Output:
 * xyz
 *
 * = Examples =
 *
 * 
 * {f:format.filesize(size: 999999, unit: 'm', precision: 3, mode: 'decimal')}
 * 
 *
 * Output:
 * xyz

• To be more meaningful to the user, the parameter size could be renamed to s.th. like bytes or sizeInBytes
• String-parameters with a fixed set of allowed values are not easy to comprehend and sometimes error prone. Instead of the mode parameter, you could have a boolean decimal or isDecimal parameter. If there will be more modes sometime, you can still refactor this, but I guess thats a case of YAGNI ;)
• its not easy to understand, what $this->modes[$mode] is at the first glance. With the above suggestion it might be rewritten to

  $quotient = $isDecimal ? 1000 : 1024;

Apart from that, it's a very neat and useful ViewHelper, thanks for sharing!

Added a new version with some changes and new features.
Now it's possible to define a decimal and a thousands separator.

Bastian, some of your suggestions found their way into the new version.
Regarding the suggestion to change the 'size' attribute I am not sure
if we should do that, because 'size' is rather short and I think it's
describing what to provide, very well. Maybe we can find another phrase
for it, which is still short but matches better.

Added 3 different usage examples. Now it's possible to choose
from 3 different syntaxes, 2 of them beeing tag-based.

I renamed the 'precision' attribute to 'decimals' to be in sync
with other viewhelpers, which are already in Fluid. Also the 2
new attributes 'decimalSeparator' and 'thousandsSeparator' are
named exactly the same like the ones in the Fluid number view helper.

Please add more feedback, I'm also for getting a polished version
of the filesize viewhelper into the package or even into Fluid.

How about renaming the VH to format.byte? The VH does not depend on a file in any way - this way the naming is more suitable.

After all I'd like to have some "auto-detection" of the best suitable output-format. Consider having files with high variety sizes (like 5kB to 100Mb) - you won't find any parameters for the VH that allows rendering in a nice way. But this would make it much simpler to use. We could either entangle this functionality in the current version or create a new one. Benefit of the second version would be easier handling in templates (<f:render.byteAuto size="123567890" /> looks better than <f:render.byte size="123567890" auto="1" />).

I append a viewHelper I wrote for that purpose. Its a bit customized and not configurable yet but might be a good example on how the viewHelper could look like.

Attached is an updated version. It has the new feature Christian proposed;
now you can define a calculation threshold. If the final size is greater than
the threshold, the next unit is chosen and the value is recalculated.
Also a little bug was fixed in this version where an exact filesize
of 1024 Bytes would still stay 1024 B, instead of converting to 1 KiB.
(And even 1024 KiB would stay, not converting to 1 MiB, and so on.)
What's still missing is a check if we run out of the SI units.
Have fun!

Attached a new version which corrects some bugs when the threshold was set to 0 and it also resets the units array for every call, to calculate a correct filesize. Also removed unneeded whitespace.