Bug #879

setValidator et al. are misleading method names

Added by Robert Lemke about 7 years ago. Updated almost 5 years ago.

Status:Closed Start date:2008-06-26
Priority:Could have Due date:
Assigned To:Andreas Förthner % Done:

0%
Category:MVC
Target version:- Estimated time:0.00 hour
PHP Version: Complexity:
Has patch: Affected Flow version:

Description

Method names such "setValidator" imply that the expected argument actually is a validator object. However in F3_FLOW3_MVC_Controller_Argument the expected argument is a class name.

Either rename the method to setNewValidator or change the method signature.

There are also a lot of tests missing for new methods introduced to F3_FLOW3_MVC_Controller_Argument.

History

#1 Updated by Karsten Dambekalns over 6 years ago

  • Status changed from New to Closed

Has been obsoleted by recent changes.

Also available in: Atom PDF