Task #8835
Remove @version annotation from FLOW3 classes
| Status: | Resolved | Start date: | 2010-07-13 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Karsten Dambekalns | % Done: | 100% |
|
| Category: | - | |||
| Target version: | TYPO3 Flow Base Distribution - 1.0 alpha 11 | |||
| Sprint: | Has patch: | |||
| PHP Version: | Complexity: |
Description
Currently each PHP class contains the following line
* @version $Id: $
That is replaced by SVN clients (if configured correctly) before comitting.
With the move to Git that won't be the case any longer, so we should get rid of these annotations.
AFAIK there is no corresponding feature in Git, but IMO we don't need the revision in the file or have any of you ever counted on the @version annotation? Besides, it makes backporting a very tedious job.
Note: If we decide to remove this annotation, we'll have to adjust the CGL document on http://flow3.typo3.org/documentation/coding-guidelines/ too
Related issues
Associated revisions
[-TASK] FLOW3 Base Distribution: Removed @version keyword from files, relates to #8835.
Change-Id: I6d1caf01abaf274f7dc4d2bda4eaa707c70c2891
[-TASK] FLOW3: Removed @version keyword from files, resolves #8835.
Change-Id: Ic27d691b7fdb82d9646ecd7c84b3759644b448f5
History
#1 Updated by Manuel Strausz about 5 years ago
A related issue seems to be the $Revision keyword expansion, which is set in the Bootstrap:
/**
* FLOW3's Subversion revision
*/
const REVISION = '$Revision: 4443 $';
I only saw this in use for the Configurations-Cache include (e.g. in 'Configurations/Production/ProductionConfigurations.php'), where it is used to make sure no obsolete cache is loaded when the framework revision changed, so this would have to be solved in a different way.
#2 Updated by Bastian Waidelich about 5 years ago
Manuel Strausz wrote:
A related issue seems to be the $Revision keyword expansion, which is set in the Bootstrap:
Good catch! We'll have to find a new mechanism for that.
#3 Updated by Karsten Dambekalns about 5 years ago
- Status changed from New to Accepted
- Assigned To set to Karsten Dambekalns
- Target version set to 1.0 alpha 11
Assigning this to me, as it needs to be done with the Git move anyway... :)
#4 Updated by Karsten Dambekalns almost 5 years ago
Some helper, for the record:
find ./ -name '*.php' -exec perl -i.bak -ne 'print unless /\@version/' {} \;
#5 Updated by Karsten Dambekalns almost 5 years ago
- Status changed from Accepted to Resolved
- % Done changed from 0 to 100
Applied in changeset r4969.