Bug #19423

Edit in Rich Text Editor - Button doesn't work anymore in Web>Page

Added by Daniel Krupke almost 7 years ago. Updated almost 7 years ago.

Status:Resolved Start date:2008-10-06
Priority:Must have Due date:
Assigned To:Oliver Hader % Done:

0%

Category:- Spent time: -
Target version:-
TYPO3 Version: Is Regression:
PHP Version: Sprint Focus:
Complexity:

Description

If any user or admin clicks on the button "Edit in Rich Text Editor" in Web>Page Module for any text content element, this results in a broken Rich Text Editor (rtehtmlarea).

This is reproducable in TYPO3 4.2.2 with Firefox, IE7, Chrome and Opera. It also occurs with a new clean TYPO3 4.2.2 installation.

See attached screenshots.

Firefox error console says:
Error: TBE_EDITOR is not defined
Source: http://.../typo3/wizard_rte.php?&P[table]=tt_content&P[uid]=307&P[pid]=10&P[field]=bodytext&P[returnUrl]=%2Ftypo3%2Fsysext%2Fcms%2Flayout%2Fdb_layout.php%3Fid%3D10
Line: 204

(issue imported from #M9497)

snapshot1-openrichtexteditor.png (95.7 kB) Administrator Admin, 2008-10-06 16:42

snapshot2-richtexteditor-opened-view.png (54.5 kB) Administrator Admin, 2008-10-06 16:42

0009497_trunk.patch Magnifier (2.8 kB) Administrator Admin, 2008-10-08 11:18

0009497_4-2.patch Magnifier (3.8 kB) Administrator Admin, 2008-10-08 11:18


Related issues

related to Core - Bug #18855: Wrong JavaScript inclusion in t3lib_TCEforms Closed 2008-05-26
related to Core - Bug #19485: Frontend Editing does not work anymore Closed 2008-10-21
duplicated by Core - Bug #19442: When inserting prices in tx_commerce the input is always ... Resolved 2008-10-09
duplicated by Core - Bug #19452: RTE broken in 4.2.2 Closed 2008-10-13
duplicated by Core - Bug #19437: RTE doesn't work properly anymore Closed 2008-10-08
duplicated by Core - Bug #19421: Setting password for a new BE user changes the field valu... Closed 2008-10-06
duplicated by Core - Bug #19550: No RTE in full Width mode Resolved 2008-10-31
duplicated by Core - Bug #19462: rtehtmlarea 1.7.6 in Function "edit in RTE" not work Resolved 2008-10-15

History

#1 Updated by Oliver Hader almost 7 years ago

Please test the attached patch in combination with the patch provided at issue #9494

#2 Updated by Christian Hernmarck almost 7 years ago

I have problems with the patch:

...../typo3/typo3_src-4.2.2_copy# patch p0 < 0009497.patch
patching file typo3/alt_palette.php
patching file typo3/wizard_rte.php
Hunk #1 FAILED at 110.
1 out of 1 hunk FAILED -
saving rejects to file typo3/wizard_rte.php.rej
patching file typo3/mod/user/ws/workspaceforms.php
Hunk #1 succeeded at 137 with fuzz 1.
patching file typo3/sysext/cms/layout/db_layout.php
Hunk #1 succeeded at 404 with fuzz 1.
Hunk #2 FAILED at 545.
1 out of 2 hunks FAILED -- saving rejects to file typo3/sysext/cms/layout/db_layout.php.rej

/Christian

#3 Updated by Oliver Hader almost 7 years ago

Please check the attached new patches (the old one was only for Trunk):

0009497_trunk.patch - TYPO3 4.3 development (Trunk)
0009497_4-2.patch - TYPO3 4.2.x

The patches now include also the fix for issue #9494 - this has to be handled in one step an cannot be separated.

#4 Updated by Christian Hernmarck almost 7 years ago

Just implemented 0009497_4-2.patch - this fixes this rte problem on my 4.2.2 installation (no other tests...).
Thanx

#5 Updated by Tobias Liebig almost 7 years ago

The Patch 0009497_4-2.patch worked for me too (4.2.2).
It also fixes #9494 (brocken password and double fields)

#6 Updated by Tobias Liebig almost 7 years ago

i'll suggest to replace this:

function typoSetup      () {
this.passwordDummy = '********';
this.decimalSign = '.';
}
var TS = new typoSetup();

with something like:

var TS = TS || {};
TS.passwordDummy = '********';
TS.decimalSign = '.';

and do the same for all "function typoSetup" in
typo3/jsfunc.tbe_editor.js
typo3/alt_main.php
typo3/backend.php
typo3/alt_doc.php

so the order does not matter anymore, as the TS object is not overwritten, but extended.

#7 Updated by Steffen Kamper almost 7 years ago

@Tobias: looks great. Could you make a patch therefore?

@Olly: i tested #9494 and works perfect, no need for the palette-stuff imho

#8 Updated by Sebastian Michaelsen almost 7 years ago

Thanks for that quick patch

#9 Updated by Oliver Hader almost 7 years ago

Thanks for your feedback. I'm going to put the patches on the Core List tomorrow.
The changes for the "TS" thingy will go to a new issue and RFC and for TYPO3 4.3 only

#10 Updated by Daniel Krupke almost 7 years ago

Thanks for that patch. It works quite fine with TYPO3 4.2.2 environments.

#11 Updated by Leonhard Wimmer almost 7 years ago

Thank you for the patch. It works perfectly.

#12 Updated by Francois Suter almost 7 years ago

I can only add my voice to that. The patch works real fine. I hope you can submit the patch to the core list soon. And then we should probably have a hot fix 4.2.3 release.

#13 Updated by Administrator Admin almost 7 years ago

I'm a real newbie, but how do I apply the patch?

#14 Updated by Michael Stucki almost 7 years ago

Fixed in TYPO3 4.2.3 (rev. 4326) and Trunk (rev. 4327).

Also available in: Atom PDF