Bug #25985
remove obsolete check for dir media/scripts/ in Function tslib_fe::checkFileInclude
| Status: | Resolved | Start date: | 2011-04-15 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | - | % Done: | 100% |
|
| Category: | - | Spent time: | - | |
| Target version: | - | |||
| TYPO3 Version: | 4.5 | Is Regression: | ||
| PHP Version: | Sprint Focus: | |||
| Complexity: |
Description
One of the path checks of the function tslib_fe::checkFileInclude checks if the includefile is within the path media/scripts/ which is obsolete:
function checkFileInclude($incFile) {
return !$this->TYPO3_CONF_VARS['FE']['noPHPscriptInclude']
|| substr($incFile,0,14)=='media/scripts/'
|| substr($incFile,0,4+strlen(TYPO3_mainDir))==TYPO3_mainDir.'ext/'
|| substr($incFile,0,7+strlen(TYPO3_mainDir))==TYPO3_mainDir.'sysext/'
|| substr($incFile,0,14)=='typo3conf/ext/';
}
Related issues
Associated revisions
[TASK] remove obsolete check for media/scripts/
tslib_fe::checkFileInclude() still contains a check for the
obsolete directory media/scripts/.
Change-Id: I2b59bd53ac0339a2cdf238cc1bbdb5f0b7c28302
Resolves: #25985
Releases: 4.7
Reviewed-on: http://review.typo3.org/8850
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
History
#1 Updated by Patrick Rodacker over 4 years ago
I think this should be also related to the task #24954
#2 Updated by Gerrit Code Review over 3 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8850
#3 Updated by Markus Klein over 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 84964aca88cf3a71840f6629b78d9878bc61e46e.