Bug #43730

Update outdated description of ['FE']['noPHPscriptInclude'] in DefaultConfiguration.php

Added by Chris topher over 2 years ago. Updated over 2 years ago.

Status:Resolved Start date:2012-12-07
Priority:Should have Due date:
Assigned To:- % Done:

100%

Category:Install Tool Spent time: -
Target version:6.0.1
TYPO3 Version:6.0 Is Regression:
PHP Version:5.4 Sprint Focus:
Complexity:no-brainer

Description

The description of ['FE']['noPHPscriptInclude'] in DefaultConfiguration.php currently says

If set, PHP-scripts are not included by TypoScript configurations, unless they reside in 'media/scripts/'-folder. (...)

This is not true anymore.

['FE']['noPHPscriptInclude'] is no longer checked with this folder (see typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php). Instead there is a check for typo3/ext/, typo3/sysext/ and typo3conf/ext.

So the text should read:

(...), unless they reside in the folders typo3/ext/, typo3/sysext/ or typo3conf/ext. (...)


Related issues

related to Core - Bug #25985: remove obsolete check for dir media/scripts/ in Function ... Resolved 2011-04-15
duplicated by Core - Task #43341: Update description for noPHPscriptInclude (Install Tool) Resolved 2012-11-27

Associated revisions

Revision 43ade890
Added by Diana Precup over 2 years ago

[BUGFIX] Invalid description of noPHPscriptInclude

default of ['FE']['noPHPscriptInclude'] as documented in
t3lib/stddb/DefaultConfiguration.php is not 'media/scripts/' but
one one of 'typo3/ext/', 'typo3/sysext/' or 'typo3conf/ext'

Resolves: #43730
Releases: 6.0

Change-Id: Idb5f63ffc3c555a6b096077302b8e56cd0b82983
Reviewed-on: https://review.typo3.org/17040
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision 04b3f8a3
Added by Diana Precup over 2 years ago

[BUGFIX] Invalid description of noPHPscriptInclude

default of ['FE']['noPHPscriptInclude'] as documented in
t3lib/stddb/DefaultConfiguration.php is not 'media/scripts/' but
one one of 'typo3/ext/', 'typo3/sysext/' or 'typo3conf/ext'

Resolves: #43730
Releases: 6.1, 6.0

Change-Id: Idb5f63ffc3c555a6b096077302b8e56cd0b82983
Reviewed-on: https://review.typo3.org/17727
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

History

#2 Updated by Chris topher over 2 years ago

  • Status changed from New to Under Review

#3 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17040

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/17727

#5 Updated by Diana Precup over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF