Task #3987
Inconsistent attribute naming in Form view helper
Status: | Resolved | Start date: | 2009-09-05 | |
---|---|---|---|---|
Priority: | Must have | Due date: | 2009-09-05 | |
Assigned To: | Bastian Waidelich | % Done: | 100% |
|
Category: | ViewHelpers | |||
Target version: | 1.0 | |||
Has patch: |
Description
The action link view helper uses the following attributes for specifying the action:
<f:link.action action="show" controller="Post" package="Blog" ...
The form view helper, however, uses other attribute names:
<f:form action="create" controllerName="Comment" packageName="Blog" subpackageName="Foo">
That is not only incosistent with the link view helper but also in general (we never use "packageName" but only "packageKey").
Please rename the attributes as follows:
controllerName -> controller
packageName -> package
subpackageName -> subpackage
Note that names like "controller", "package" etc. should only be used for attributes in Fluid templates. We make the exception there to provide shorter names for the users. Generally in PHP code we'd rather use "controllerName", "packageKey" etc.
Related issues
History
#1 Updated by Robert Lemke almost 6 years ago
- Target version changed from 1.0.0 alpha 3 to 1.0
#2 Updated by Bastian Waidelich almost 6 years ago
- Assigned To set to Bastian Waidelich
I'll take care of that during the UriBuilder rewrite (90% finished)
#4 Updated by Bastian Waidelich almost 6 years ago
Applied in changeset r3131.
#5 Updated by Bastian Waidelich almost 6 years ago
- Status changed from New to Resolved