Feature #4457
Improve UriBuilder
| Status: | Resolved | Start date: | 2009-09-04 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Karsten Dambekalns | % Done: | 100% |
|
| Category: | MVC | |||
| Target version: | TYPO3 Flow Base Distribution - 1.0 alpha 4 | |||
| PHP Version: | Complexity: | |||
| Has patch: |
Description
As discussed in the mailing lists, the current UriBuilder is not really flexible and extensible.
Besides it does not follow the FLOW3 CGL ("URIBuilder" should be "UriBuilder", "URIFor()" => "uriFor()").
In Extbase the UriBuilder is already rewritten (See #3981). These changes need to be "forward ported" to FLOW3.
Patch follows.
4457_Improve_UriBuilder.patch
- patch for package "FLOW3"
(32.8 kB)
4457_Fluid.patch
- patch for package "Fluid"
(13.9 kB)
4457_DocumentationBrowser.patch
- patch for package "DocumentationBrowser"
(1.2 kB)
4457_DocumentationBrowser.zip (2.3 kB)
4457_FLOW3.zip (30.8 kB)
4457_Fluid.zip (11.1 kB)
4457_Fluid_v2.patch
(14 kB)
Related issues
History
#1 Updated by Bastian Waidelich almost 6 years ago
- File 4457_Improve_UriBuilder.patch added
- File 4457_Fluid.patch added
- File 4457_DocumentationBrowser.patch added
- Assigned To changed from Bastian Waidelich to Robert Lemke
Attached patches improves the UriBuilder as described and adjusts packages "Fluid" and "DocumentationBrowser" accordingly.
Please check and commit if applicable.
#2 Updated by Bastian Waidelich almost 6 years ago
Bastian Waidelich wrote:
Attached patches improves the UriBuilder as described [...]
BTW: The patch even brings some new features like $uriBuilder->setAddQueryString() and $uriBuilder->setArgumentsToBeExcludedFromQueryString() which will be useful for complex scenarios
#3 Updated by Bastian Waidelich almost 6 years ago
BTW²: The patch resolves #3987 too.
#4 Updated by Karsten Dambekalns almost 6 years ago
- Status changed from New to Accepted
- Assigned To changed from Robert Lemke to Karsten Dambekalns
#5 Updated by Karsten Dambekalns almost 6 years ago
- Target version set to 1.0 alpha 4
#6 Updated by Bastian Waidelich almost 6 years ago
- File 4457_DocumentationBrowser.zip added
- File 4457_FLOW3.zip added
- File 4457_Fluid.zip added
If the patches won't apply cleanly, you can replace the files manually (see attached zip archives)
#7 Updated by Bastian Waidelich almost 6 years ago
- File 4457_Fluid_v2.patch added
Attached you'll find a tweaked version of the Fluid patch:
Link/ActionViewHelper & Uri/ActionViewHelper did not call reset() on UriBuilder before creating the URI.
#8 Updated by Karsten Dambekalns almost 6 years ago
- Status changed from Accepted to Resolved
- % Done changed from 0 to 100
Resolved as of r3131 (somehow i forgot the commit message with that change).