Bug #44535
Subclasses of SplObjectStorage, ArrayObject, Collection not considered collection type
| Status: | Resolved | Start date: | 2013-01-15 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Karsten Dambekalns | % Done: | 100% |
|
| Category: | Utility | |||
| Target version: | TYPO3 Flow Base Distribution - 2.0 | |||
| PHP Version: | Complexity: | easy | ||
| Has patch: | No | Affected Flow version: | (any) |
Description
TypeHandling::isCollectionType() does not consider inheritance when it comes to the checking it does. Thus a subclass of SplObjectStorage or an implementation of Doctrine's Collection interface will not pass the check.
Related issues
Associated revisions
[BUGFIX] Check inheritance in TypeHandling::isCollectionType()
With this change TypeHandling::isCollectionType() does consider
inheritance when it comes to the checking it does. Thus a subclass of
SplObjectStorage or an implementation of Doctrine's Collection interface
will now be seen as a collection type.
Change-Id: I007b0faf486680ecfb2fe7c753ef4cabcf6d618c
Fixes: #44535
Releases: master, 2.0, 1.1
[BUGFIX] Check inheritance in TypeHandling::isCollectionType()
With this change TypeHandling::isCollectionType() does consider
inheritance when it comes to the checking it does. Thus a subclass of
SplObjectStorage or an implementation of Doctrine's Collection interface
will now be seen as a collection type.
Change-Id: I007b0faf486680ecfb2fe7c753ef4cabcf6d618c
Fixes: #44535
Releases: master, 2.0, 1.1
[BUGFIX] Check inheritance in TypeHandling::isCollectionType()
With this change TypeHandling::isCollectionType() does consider
inheritance when it comes to the checking it does. Thus a subclass of
SplObjectStorage or an implementation of Doctrine's Collection interface
will now be seen as a collection type.
Change-Id: I007b0faf486680ecfb2fe7c753ef4cabcf6d618c
Fixes: #44535
Releases: master, 2.0, 1.1
History
#1 Updated by Karsten Dambekalns over 2 years ago
- Status changed from Accepted to Under Review
#2 Updated by Christoph Gross over 2 years ago
I get Errors after applying the Patchset: http://pastebin.com/2J84kLK1
Should be reverted.
#3 Updated by Gerrit Code Review over 2 years ago
Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19063
#4 Updated by Gerrit Code Review over 2 years ago
Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at https://review.typo3.org/19064
#5 Updated by Karsten Dambekalns over 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 59c0976870264f59ca88b186f27b2a89c4c2cd4e.
#6 Updated by Gerrit Code Review over 2 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch FLOW3-1.1 has been pushed to the review server.
It is available at https://review.typo3.org/19064
#7 Updated by Karsten Dambekalns about 2 years ago
- Status changed from Under Review to Resolved