TYPO3.Flow

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18556

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18556

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18556

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18556

The current patchset fails in my installation (LAMP) because the following Type is not recognized as Collection:
Doctrine\ORM\PersistentCollection

IMHO is_subclass_of is not enough, it should also be checked for interfaces

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18556

Benno Weinzierl wrote:

The current patchset fails in my installation (LAMP) because the following Type is not recognized as Collection:
Doctrine\ORM\PersistentCollection

IMHO is_subclass_of is not enough, it should also be checked for interfaces

Not needed after 5.3.7:

php -a
Interactive shell

php > var_dump(is_subclass_of('ArrayObject', 'ArrayAccess'));
bool(true)

The question is, when can we finally raise the minimum required PHP version to something sane?

Karsten Dambekalns wrote:

What PHP version are you running?

Jup! I am running 5.3.6...

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18556

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18556

Karsten Dambekalns wrote:

The question is, when can we finally raise the minimum required PHP version to something sane?

I hope not as long as many production servers are using the current Debian (Squeeze) which uses PHP 5.3.3 at the moment. It would exclude many production servers from beeing able to run Flow or Neos. So please wait a little longer. Thanks.

not fixed in my installation. Get Error:

#1: Warning: class_implements() [<a href='function.class-implements'>function.class-implements</a>]: Class string does not exist and could not be loaded in .../Packages/Framework/TYPO3.Flow/Classes/TYPO3/Flow/Utility/TypeHandling.php line 128

Should look like this:

    static public function isCollectionType($type) {
        if (in_array($type, self::$collectionTypes, TRUE)) {
            return TRUE;
        }

        if (class_exists($type) === TRUE) {
            foreach (self::$collectionTypes as $collectionType) {
                if (is_subclass_of($type, $collectionType) === TRUE) {
                    return TRUE;
                }
            }

                // is_subclasss_of does not check for interfaces in PHP < 5.3.7
            if (version_compare(PHP_VERSION, '5.3.7', '<') === TRUE) {
                foreach (self::$collectionTypes as $collectionType) {
                    if (in_array($collectionType, class_implements($type)) === TRUE) {
                        return TRUE;
                    }
                }
            }
        }

        return FALSE;
    }

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18900

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18900

Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19056

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at https://review.typo3.org/19057

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at https://review.typo3.org/19058

Patch set 2 for branch FLOW3-1.1 has been pushed to the review server.
It is available at https://review.typo3.org/19057

Patch set 1 for branch composer has been pushed to the review server.
It is available at https://review.typo3.org/19349

Patch set 1 for branch composer has been pushed to the review server.
It is available at https://review.typo3.org/19352