Bug #51411
Label user function for sys_file_reference uses HTML
| Status: | Resolved | Start date: | 2013-08-27 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Philipp Gampe | % Done: | 100% |
|
| Category: | File Abstraction Layer (FAL) | Spent time: | - | |
| Target version: | - | |||
| TYPO3 Version: | 6.2 | Is Regression: | No | |
| PHP Version: | 5.3 | Sprint Focus: | ||
| Complexity: | easy |
Description
The label user function for sys_file_reference uses HTML which results in strange data in the workspace module, the admin log and possibly also in other components that list sys_file_reference records in a list (see attached screenshots).
This behaviour has been introduced with this change:
https://review.typo3.org/21916
Related issues
Associated revisions
[BUGFIX] Label user function for sys_file_reference uses HTML
The change I7770044c11a6c1a1bcb51a3bfc11b85923653196 added meta
information for the FAL IRRE headers.
It uses a definition list to show certain fields of the related record
inside the title (thus visible if collapsed).
The HTML markup leads to problems in other places of the backend, most
noteable in the workspace module.
Introduce a separate user function only for inline labels,
using the same signature as the normal label_userFunc.
Resolves: #51411
Releases: 6.2
Change-Id: I070a9db3d009c743cb927be90a0aa3903a1bae45
Reviewed-on: https://review.typo3.org/23528
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
History
#1 Updated by Markus Klein almost 2 years ago
What do you propose to change here?
What do you want to see as label in the Workspace Module?
I'd say we change the InlineElement.php to add another option/parameter/whatever to the userfunc called, such that the userfunc can distinguish between normal labeling and inline labeling.
#2 Updated by Philipp Gampe almost 2 years ago
IMHO a bug of the inline label part ... there should be two seperate functions for labels. One for TCEfroms and one for inline labels in the backend.
#3 Updated by Philipp Gampe almost 2 years ago
- Status changed from New to Needs Feedback
#4 Updated by Gerrit Code Review almost 2 years ago
- Status changed from Needs Feedback to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23528
#5 Updated by Philipp Gampe almost 2 years ago
- Assigned To set to Philipp Gampe
I changed this to a new config option inlineLabel_userFunc with the same signature as the label_userFunc.
The function InlineElement::renderForeignRecordHeader is only called from InlineElement::renderForeignRecord which in turn is only used to render IRRE fields AFAICT.
That way all other places preserve the behavior.
#6 Updated by Gerrit Code Review almost 2 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23528
#7 Updated by Gerrit Code Review almost 2 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23528
#8 Updated by Gerrit Code Review almost 2 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23528
#9 Updated by Ernesto Baschny almost 2 years ago
- Priority changed from Should have to Must have
- Is Regression set to No
#10 Updated by Gerrit Code Review almost 2 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23528
#11 Updated by Philipp Gampe almost 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 04dcfbc72da6616552dcb2c2c676cf07ebeb33ce.