Task #51807
Epic #55070: Workpackages
Epic #54260: WP: FAL Missing Issues / Features / API
Story #54272: As an Editor I expect FAL to work with the RTE
RTE MagicImage should use the FAL processing API and not storage-0
| Status: | Resolved | Start date: | 2013-09-06 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Stanislas Rolland | % Done: | 100% |
|
| Category: | rtehtmlarea | Spent time: | 20.00 hours | |
| Target version: | - | Estimated time: | 20.00 hours | |
| TYPO3 Version: | 6.0 | Complexity: | ||
| PHP Version: | Sprint Focus: |
Description
RTE MagicImageService relies on storage 0 and does create "magic" images by using ImageMagick functions
directly instead of using the FAL processing API.
This leads to several problems after adding restrictions to storage 0
Uncaught_TYPO3_Exception_1375955684.txt
(6.3 kB)
Uncaught_TYPO3_Exception_RTE_image_fileadmin_processed.txt
(4.3 kB)
Related issues
Associated revisions
[TASK] RTE MagicImage should use FAL processing API
The RTE magic still copies images to the old upload folder and
does not use the processed file functions of FAL.
This patch changes the RTE magic so storage 0 is not used any more
and that the FAL API is used for processing the images.
Resolves: #51807
Releases: 6.2
Change-Id: I07d609f9e638d79e785be4ebfd25631c70e3d141
Reviewed-on: https://review.typo3.org/23663
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
History
#1 Updated by Helmut Hummel almost 2 years ago
- Category changed from File Abstraction Layer (FAL) to 1394
#2 Updated by Helmut Hummel almost 2 years ago
- File Uncaught_TYPO3_Exception_1375955684.txt added
Add RTE related exception from #51747
#3 Updated by Helmut Hummel almost 2 years ago
Add RTE related exception from #51747
#4 Updated by Helmut Hummel almost 2 years ago
- File Uncaught_TYPO3_Exception_RTE_image.txt added
Add RTE related exception from #51747
#5 Updated by Ernesto Baschny almost 2 years ago
- Target version set to next-patchlevel
This is a dupe of #51778, right, Helmut? Could we continue on the older one only?
#6 Updated by Helmut Hummel almost 2 years ago
OK, for anybody having problems with the current release, please try out this
https://review.typo3.org/23660 (patch set 5)
It rolls back permission restrictions for storage 0 and should solve all problems with RTE and old extensions (like tt_news)
#7 Updated by Ernesto Baschny almost 2 years ago
- Is Regression set to Yes
#8 Updated by Ernesto Baschny almost 2 years ago
- Category changed from 1394 to rtehtmlarea
#9 Updated by Jürgen König almost 2 years ago
Thank you, this works for me. I can insert images in RTE again and open tx_news news.
The ResourceStorage.php does not work in this version. It throws the isMissing-Error mentioned in http://forge.typo3.org/issues/51747.
I used the original file and changed the three lines and it worked.
Thank you Thank you Thank you...
#10 Updated by Ernesto Baschny almost 2 years ago
- Tracker changed from Bug to Task
- Subject changed from RTE Images do not work because exceptions are thrown to RTE MagicImage should use the FAL processing API and not storage-0
- Target version deleted (
next-patchlevel)
The bug is already solved by #51808, but anyway we want to keep this open to rework rtehtmlarea to make proper use of the FAL API in future.
I changed the subject acordingly and made it a Task. I asked Stan if he could work on that.
#11 Updated by Gerrit Code Review almost 2 years ago
- Status changed from Accepted to Under Review
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23663
#12 Updated by Ernesto Baschny almost 2 years ago
- Tracker changed from Task to Bug
#13 Updated by Ernesto Baschny almost 2 years ago
- Is Regression changed from Yes to No
#14 Updated by Ernesto Baschny almost 2 years ago
- Tracker changed from Bug to Task
#15 Updated by Ernesto Baschny over 1 year ago
- Parent task set to #54272
#16 Updated by Stanislas Rolland over 1 year ago
- Estimated time set to 16.00
- Remaining (hours) set to 16.0
#17 Updated by Stanislas Rolland over 1 year ago
- Assigned To set to Stanislas Rolland
#18 Updated by Gerrit Code Review over 1 year ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23663
#19 Updated by Gerrit Code Review over 1 year ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23663
#20 Updated by Gerrit Code Review over 1 year ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23663
#21 Updated by Gerrit Code Review over 1 year ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23663
#22 Updated by Gerrit Code Review over 1 year ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23663
#23 Updated by Gerrit Code Review over 1 year ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23663
#24 Updated by Stanislas Rolland over 1 year ago
- % Done changed from 0 to 80
- Estimated time changed from 16.00 to 20.00
#25 Updated by Gerrit Code Review over 1 year ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23663
#26 Updated by Stanislas Rolland over 1 year ago
- % Done changed from 80 to 100
#27 Updated by Stanislas Rolland over 1 year ago
- Status changed from Under Review to Resolved
Applied in changeset 0984d6d3f9a1dd93480397c299446009d50f7786.
#28 Updated by Stanislas Rolland over 1 year ago
- Estimated time changed from 20.00 to 21.00
#29 Updated by Stanislas Rolland over 1 year ago
- Estimated time changed from 21.00 to 20.00