Bug #51808

ProcessedFiles need to be able to do file exists in processing folder without permission checks

Added by Helmut Hummel almost 2 years ago. Updated almost 2 years ago.

Status:Resolved Start date:2013-09-06
Priority:Should have Due date:
Assigned To:- % Done:

100%

Category:File Abstraction Layer (FAL) Spent time: -
Target version:next-patchlevel
TYPO3 Version:6.0 Is Regression:Yes
PHP Version: Sprint Focus:
Complexity:

1375955684.txt Magnifier (8 kB) Helmut Hummel, 2013-09-06 12:20

1375955684_pagemodule_dmnkhhn.txt Magnifier (6.9 kB) Helmut Hummel, 2013-09-06 12:20

1375955684_listmodule_dmnkhhn.txt Magnifier (6.1 kB) Helmut Hummel, 2013-09-06 12:20

Uncaught_TYPO3_Exception_tx_news_sysfolder.txt Magnifier (8 kB) Helmut Hummel, 2013-09-06 12:20

Uncaught_1376992145.txt Magnifier (4.5 kB) Andrea Böhm, 2013-09-06 20:34

Uncaught_1314354065.txt Magnifier (7.9 kB) Andrea Böhm, 2013-09-06 20:40


Related issues

related to Core - Bug #51747: Fatal Error after upgrading to 6.0.9 and 6.1.4 and deleti... Resolved 2013-09-04
related to Core - Task #51807: RTE MagicImage should use the FAL processing API and not ... Resolved 2013-09-06
duplicated by Core - Bug #51858: Fatal error on objects using uploads/tx_...... after upgr... Closed 2013-09-09

Associated revisions

Revision 4bf5e79f
Added by Helmut Hummel almost 2 years ago

[BUGFIX] Enable ProcessedFiles to do file exists

Make storage 0 folder readable, browsable and writable
to mitigate the problems that arise with non
readable processing directories.

Also allow file exists in general if the
identifier in subject is in processing folder.

Resolves: #51808
Releases: 6.0, 6.1, 6.2
Change-Id: I1959d7911d955592db1771d608e8fafcc26c45e9
Reviewed-on: https://review.typo3.org/23660
Reviewed-by: Horst-Dietrich Frank
Tested-by: Horst-Dietrich Frank
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jakob Hombsch
Tested-by: Jakob Hombsch
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Revision 714d34ed
Added by Helmut Hummel almost 2 years ago

[BUGFIX] Enable ProcessedFiles to do file exists

Make storage 0 folder readable, browsable and writable
to mitigate the problems that arise with non
readable processing directories.

Also allow file exists in general if the
identifier in subject is in processing folder.

Resolves: #51808
Releases: 6.0, 6.1, 6.2
Change-Id: I1959d7911d955592db1771d608e8fafcc26c45e9
Reviewed-on: https://review.typo3.org/23664
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Revision 3d4d7853
Added by Helmut Hummel almost 2 years ago

[BUGFIX] Enable ProcessedFiles to do file exists

Make storage 0 folder readable, browsable and writable
to mitigate the problems that arise with non
readable processing directories.

Also allow file exists in general if the
identifier in subject is in processing folder.

Resolves: #51808
Releases: 6.0, 6.1, 6.2
Change-Id: I1959d7911d955592db1771d608e8fafcc26c45e9
Reviewed-on: https://review.typo3.org/23665
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

History

#1 Updated by Helmut Hummel almost 2 years ago

  • Status changed from New to Accepted

#2 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23660

#3 Updated by Dominik Hahn almost 2 years ago

I've applied the patch but the problems I reported earlier (=> http://forge.typo3.org/issues/51747#note-41) remain.

Does this patch and patch 6 (ticket #51747) work together or do I have to reset all files prior to applying this patch?

#4 Updated by Philipp Gampe almost 2 years ago

@Dominik please report your test results directly in gerrit. You may set the verified state to -1.
Hint: Gerrit uses the same login data as for typo3.org or forge.

#5 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23660

#6 Updated by Helmut Hummel almost 2 years ago

Dominik Hahn wrote:

I've applied the patch but the problems I reported earlier (=> http://forge.typo3.org/issues/51747#note-41) remain.

Does this patch and patch 6 (ticket #51747) work together or do I have to reset all files prior to applying this patch?

OK, read permissions to files is still required. can you check out patch set 2?

#7 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23660

#8 Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23660

#9 Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23660

#10 Updated by Helmut Hummel almost 2 years ago

OK, for anybody having problems with the current release, please try out this

https://review.typo3.org/23660 (patch set 5)

It rolls back permission restrictions for storage 0 and should solve all problems with RTE and old extensions (like tt_news)

#11 Updated by Andrea Böhm almost 2 years ago

With this patch set editors can insert images via RTE again.

Thanks Helmut!

#12 Updated by Ernesto Baschny almost 2 years ago

  • Is Regression set to Yes

#13 Updated by Ernesto Baschny almost 2 years ago

  • Category changed from 1394 to File Abstraction Layer (FAL)
  • Target version set to next-patchlevel

#14 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23664

#15 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/23665

#16 Updated by Helmut Hummel almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#17 Updated by Andrea Böhm almost 2 years ago

while these patches resolve the RTE images issues they introduce a minor issue in the filelist module.

It is not a mayor bug but I want to mention it:
The filelist module now shows the processed folder. Clicking on this folder leads to an exception #1376992145 (see attachted file).

Update: see next post

#18 Updated by Andrea Böhm almost 2 years ago

Sorry - I've attached the wrong file - exception #1314354065 is the correct one.

Also available in: Atom PDF