Task #54234
Epic #55070: Workpackages
Epic #54260: WP: FAL Missing Issues / Features / API
Story #54267: As an Editor I want to use a FAL withouth bugs
Prevent creation of FileObjects for ProcessedFiles
| Status: | Resolved | Start date: | 2013-12-06 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Steffen Ritter | % Done: | 100% |
|
| Category: | File Abstraction Layer (FAL) | Spent time: | 4.00 hours | |
| Target version: | 6.2.0 | Estimated time: | 4.00 hours | |
| TYPO3 Version: | 6.2 | Complexity: | ||
| PHP Version: | Sprint Focus: |
Related issues
Associated revisions
[TASK] Return ProcessedFile instead of File if possible
You can query the FAL-API for files by their filename. If the file resides
in the processing-folder of a storage it is a valid file to the storage.
Therefore creating a file-object and indexing it would be a valid thing.
Since this is not intended additionally to the storage the ResourceFactory
must know about that, too. This change implements this awareness, so there
is no way to create a FileObject for files which reside within the
processing folder.
In 6.0 and 6.1 there has been a dirty workaround for that by marking those
files as not indexable which was removed silently when introducing the new
indexer.
Releases: 6.2
Resolves: #54234
Change-Id: I274c47717560a6efc175fa94aacc4770a578fd3f
Reviewed-on: https://review.typo3.org/27753
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Markus Klein
Tested-by: Markus Klein
[BUGFIX] Index on sys_file_processedfile is too large
Resolves: #56786
Related: #54234
Releases: 6.2
Change-Id: I9c91f3e989e65df559542135d0b84025dacbbaf2
Reviewed-on: https://review.typo3.org/28272
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
[BUGFIX] Index on sys_file_processedfile is still too large
On some systems even "332" characters is too large. To also cope with
potential utf8mb4 setups (1 char = 4 bytes), and staying under 1000 byte
limit, we reduce the amount of characters in the index to 249.
Resolves: #56786
Related: #54234
Releases: 6.2
Change-Id: I79452224f37ec2b6ca5b3a35044144eed787df67
Reviewed-on: https://review.typo3.org/28429
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
History
#1 Updated by Steffen Ritter over 1 year ago
- Subject changed from Prevent creation of FileObjects to Prevent creation of FileObjects for ProcessedFiles
#2 Updated by Steffen Ritter over 1 year ago
- Parent task set to #54267
#3 Updated by Stefan Neufeind over 1 year ago
I'm not sure if that's also within scope of this patch but: Maybe trying to be able to fetch a processed-file directly giving an ID, storage and the configuration? Currently when fetching a resized image from fluid and giving it's FAL-uid first that file-object is fetched/created, process() called and then we get the processedFile. But using the ID it might even be possible to skip creating (and fetching from DB) the original file.
#4 Updated by Steffen Ritter over 1 year ago
- % Done changed from 0 to 70
#5 Updated by Gerrit Code Review over 1 year ago
- Status changed from Accepted to Under Review
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27753
#6 Updated by Gerrit Code Review over 1 year ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27753
#7 Updated by Gerrit Code Review over 1 year ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27753
#8 Updated by Gerrit Code Review over 1 year ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27753
#9 Updated by Gerrit Code Review over 1 year ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27753
#10 Updated by Gerrit Code Review over 1 year ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27753
#11 Updated by Steffen Ritter over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 70 to 100
Applied in changeset 8654649d6e2da5b0db246bd8401276a638756748.