Bug #56786

Index on sys_file_processedfile is too large

Added by Ernesto Baschny over 1 year ago. Updated over 1 year ago.

Status:Resolved Start date:2014-03-11
Priority:Should have Due date:
Assigned To:Ernesto Baschny % Done:

100%

Category:File Abstraction Layer (FAL) Spent time: -
Target version:6.2.0
TYPO3 Version:6.2 Is Regression:No
PHP Version: Sprint Focus:
Complexity:easy

Description

Since #54234 a SQL error in the Upgrade Wizard / Database Compare is left open:

ALTER TABLE sys_file_processedfile ADD KEY identifier (storage,identifier); 
Specified key was too long; max key length is 1000 bytes

"identifier" is varchar(512) but on utf8 charset every character needs 3 bytes of space. So the index is "too large" (for MyISAM).

Solution would be to limit the key to the first 332 chars.


Related issues

related to Core - Task #54234: Prevent creation of FileObjects for ProcessedFiles Resolved 2013-12-06
related to Core - Bug #57805: SQL-ERROR: Specified key was too long Resolved 2014-04-10
duplicated by Core - Bug #57002: SQL-Errors while Upgrading the database with Upgrade Wizard Resolved 2014-03-17

Associated revisions

Revision aa1fb872
Added by Ernesto Baschny over 1 year ago

[BUGFIX] Index on sys_file_processedfile is too large

Resolves: #56786
Related: #54234
Releases: 6.2
Change-Id: I9c91f3e989e65df559542135d0b84025dacbbaf2
Reviewed-on: https://review.typo3.org/28272
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Revision 7d80f335
Added by Ernesto Baschny over 1 year ago

[BUGFIX] Index on sys_file_processedfile is still too large

On some systems even "332" characters is too large. To also cope with
potential utf8mb4 setups (1 char = 4 bytes), and staying under 1000 byte
limit, we reduce the amount of characters in the index to 249.

Resolves: #56786
Related: #54234
Releases: 6.2
Change-Id: I79452224f37ec2b6ca5b3a35044144eed787df67
Reviewed-on: https://review.typo3.org/28429
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28272

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28272

#3 Updated by Ernesto Baschny over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28429

#5 Updated by Ernesto Baschny over 1 year ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF