Bug #56019

ResourceCompressor: concatenateCss with forceOnTop gives wrong order

Added by Stefan Neufeind over 1 year ago. Updated over 1 year ago.

Status:Resolved Start date:2014-02-16
Priority:Should have Due date:
Assigned To:- % Done:

100%

Category:Frontend Spent time: -
Target version:-
TYPO3 Version:6.2 Is Regression:No
PHP Version: Sprint Focus:
Complexity:

Description

While testing #53116 (about concatenateJs and forceOnTop) I also checked if that part works fine for CSS. The forceOnTop works if you don't concatenate them:

page >

config.concatenateCss = 0
page = PAGE
page {
  includeCSS {
    b = fileadmin/b.css
    b {
      forceOnTop = 0
    }
    c = fileadmin/c.css
    c {
      forceOnTop = 1
    }
    a = fileadmin/a.css
    a {
      forceOnTop = 1
    }
  }
}

gives:
<link rel="stylesheet" type="text/css" href="fileadmin/a.css?1392566437" media="all">
<link rel="stylesheet" type="text/css" href="fileadmin/c.css?1392566430" media="all">

<link rel="stylesheet" type="text/css" href="typo3temp/stylesheet_993134cfc3.css?1385132976" media="all">
<link rel="stylesheet" type="text/css" href="fileadmin/b.css?1392566433" media="all">

(okay, we might look if we can get rid of that newline in the middle)

But with config.concatenateCss = 1 the order is then:
  • default CSS
  • b
  • c
  • a
Expected behaviour (as in non-concatenated example):
  • a
  • c
  • default CSS
  • b

Related issues

related to Core - Bug #53116: concatenateJs in conjunction with forceOnTop Resolved 2013-10-25
related to TypoScript Reference (TSref) - Bug #56021: Missing info about "forceOnTop" for includeCSS Resolved 2014-02-16

Associated revisions

Revision 599cdb66
Added by Markus Klein over 1 year ago

[BUGFIX] concatenateJs/Css does not consider forceOnTop

Setting the forceOnTop property for a JS or CSS file is not
observed if concatenateJs/Css is set as well.

Resolves: #53116
Resolves: #56019
Releases: 6.2, 6.1
Change-Id: Ica31656bd72f4a0249513206bac45aa16b929761
Reviewed-on: https://review.typo3.org/27640
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Revision c9ae284b
Added by Markus Klein over 1 year ago

[BUGFIX] concatenateJs/Css does not consider forceOnTop

Setting the forceOnTop property for a JS or CSS file is not
observed if concatenateJs/Css is set as well.

Resolves: #53116
Resolves: #56019
Releases: 6.2, 6.1
Change-Id: Ica31656bd72f4a0249513206bac45aa16b929761
Reviewed-on: https://review.typo3.org/27672
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

History

#1 Updated by Markus Klein over 1 year ago

Hi! I checked that too, but forceOnTop for includeCSS is not documented to exist.

http://docs.typo3.org/typo3cms/TyposcriptReference/latest/Setup/Page/#includecss-array

#2 Updated by Stefan Neufeind over 1 year ago

Oh my :-( But it works if you don't concatenate. Imho then we should:
  • fix it for the concatenate-case as a "TASK" (make the functionality complete)
  • document it

#3 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27640

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27640

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27672

#6 Updated by Markus Klein over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF