Bug #53116

Epic #55575: Streamline JavaScript Code in the TYPO3 Backend

concatenateJs in conjunction with forceOnTop

Added by Matthias Kappenberg almost 2 years ago. Updated over 1 year ago.

Status:Resolved Start date:2013-10-25
Priority:Must have Due date:
Assigned To:- % Done:

100%
Category:Frontend Spent time: -
Target version:-
TYPO3 Version:6.1 Is Regression:No
PHP Version: Sprint Focus:
Complexity:

Description

Hi All,

if I'm right the Typoscript setting "forceOnTop" has no effect in conjuntion with "concatenateJs".

Please try:

config {
  concatenateJs = 1
}

page {
  includeJSFooter {
    somefile = path/to/functions.js
    someotherfile = path/to/functions.js
    someotherfile.forceOnTop = 1
  }
}

If concatenateJs is disabled, it's working.

Can you confirm this behavior?

Related issues

related to Core - Bug #56019: ResourceCompressor: concatenateCss with forceOnTop gives ... Resolved 2014-02-16
related to Core - Bug #56242: Fix JS concatenation if first file is forceOnTop = 1 Resolved 2014-02-24
duplicated by Core - Bug #56233: Load order of js files differs Closed 2014-02-24

Associated revisions

Revision 599cdb66
Added by Markus Klein over 1 year ago

[BUGFIX] concatenateJs/Css does not consider forceOnTop

Setting the forceOnTop property for a JS or CSS file is not
observed if concatenateJs/Css is set as well.

Resolves: #53116
Resolves: #56019
Releases: 6.2, 6.1
Change-Id: Ica31656bd72f4a0249513206bac45aa16b929761
Reviewed-on: https://review.typo3.org/27640
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Revision c9ae284b
Added by Markus Klein over 1 year ago

[BUGFIX] concatenateJs/Css does not consider forceOnTop

Setting the forceOnTop property for a JS or CSS file is not
observed if concatenateJs/Css is set as well.

Resolves: #53116
Resolves: #56019
Releases: 6.2, 6.1
Change-Id: Ica31656bd72f4a0249513206bac45aa16b929761
Reviewed-on: https://review.typo3.org/27672
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

History

#1 Updated by Markus Klein over 1 year ago

  • Status changed from New to Accepted
  • Priority changed from Should have to Must have

#2 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27640

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27640

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27640

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27672

#6 Updated by Markus Klein over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Daniel Siepmann over 1 year ago

  • Parent task set to #55575

Also available in: Atom PDF