Bug #56233
Epic #55575: Streamline JavaScript Code in the TYPO3 Backend
Load order of js files differs
Status: | Closed | Start date: | 2014-02-24 | |
---|---|---|---|---|
Priority: | Should have | Due date: | ||
Assigned To: | Daniel Siepmann | % Done: | 0% |
|
Category: | Frontend | Spent time: | - | |
Target version: | - | |||
TYPO3 Version: | 4.7 | Is Regression: | No | |
PHP Version: | 5.3 | Sprint Focus: | ||
Complexity: |
Description
There is a difference of ordering for js files, in case they are compressed / concatenated or not.
Looks like pagerenderer inverses the "forceOnTop files" while the ResourceCompressor doesn't.
if ($properties['forceOnTop']) { if ($properties['section'] === self::PART_HEADER) { $jsFiles = $tag . LF . $jsFiles; } else { $jsFooterFiles = $tag . LF . $jsFooterFiles; } } else { if ($properties['section'] === self::PART_HEADER) { $jsFiles .= LF . $tag; } else { $jsFooterFiles .= LF . $tag; } }
Instead of prepanding the file we should use the same logic as in ResourceCompressor. We should build arrays for each kind of section and merge them at the end.
The change of order should be communicated on launch. That's a breaking change for JS developers. They have to check the order of there JS files.
Related issues
History
#1 Updated by Daniel Siepmann over 1 year ago
Getting deeper, it looks like pagerenderer is right and Compressor should take care of forceOnTop. Currently this setting is just ignored.
#2 Updated by Markus Klein over 1 year ago
Wait a bit, there's already a patch of mine pending I guess.
#3 Updated by Markus Klein over 1 year ago
- Target version deleted (
6.2.0)
#4 Updated by Daniel Siepmann over 1 year ago
- Parent task set to #55575
#5 Updated by Benjamin Mack 6 months ago
- Status changed from New to Closed