Bug #56242
Fix JS concatenation if first file is forceOnTop = 1
| Status: | Resolved | Start date: | 2014-02-24 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Markus Klein | % Done: | 100% |
|
| Category: | Backend API | Spent time: | - | |
| Target version: | next-patchlevel | |||
| TYPO3 Version: | 6.1 | Is Regression: | No | |
| PHP Version: | Sprint Focus: | |||
| Complexity: | easy |
Description
Fix an edge-case caused by #53116
Affected are 6.1 and 6.2.
Related issues
Associated revisions
[BUGFIX] Fix JS concat if first file is forced on top
If a javascript file is forceOnTop the script uses array_unshift()
to put the file at the beginning of the section array. If this is
the first file that got processed, the array does not exist yet,
so the array_unshift function returns NULL and the file
will not added to the array.
The fix properly initalizes the section sub-array.
Resolves: #56242
Releases: 6.2, 6.1
Change-Id: I23af7862263fb0685032c34ded8736df87ddeb99
Reviewed-on: https://review.typo3.org/27793
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
[BUGFIX] Fix JS concat if first file is forced on top
If a javascript file is forceOnTop the script uses array_unshift()
to put the file at the beginning of the section array. If this is
the first file that got processed, the array does not exist yet,
so the array_unshift function returns NULL and the file
will not added to the array.
The fix properly initalizes the section sub-array.
Resolves: #56242
Releases: 6.2, 6.1
Change-Id: Iadf2b6f2f512929ff5e8598af9972c5337949341
Reviewed-on: https://review.typo3.org/27818
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
History
#1 Updated by Gerrit Code Review over 1 year ago
- Status changed from Accepted to Under Review
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27793
#2 Updated by Gerrit Code Review over 1 year ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27793
#3 Updated by Gerrit Code Review over 1 year ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27793
#4 Updated by Gerrit Code Review over 1 year ago
Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27818
#5 Updated by Benjamin Kott over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 5da89e21c57af2a43b896296fadf3699ff78fbb2.