Bug #56077

Blocking errors if files deleted

Added by Thomas Sperling over 1 year ago. Updated over 1 year ago.

Status:Resolved Start date:2014-02-18
Priority:Should have Due date:
Assigned To:- % Done:

100%
Category:File Abstraction Layer (FAL) Spent time: -
Target version:-
TYPO3 Version:6.2 Is Regression:No
PHP Version: Sprint Focus:
Complexity:

Description

If you delete files on the server (without TYPO3) you can get blocking errors as editor.

My specific case was the thumbnails of tt_news in listview. If the connected image does not exist you get an error ('File xyz does not exist' thrown in LocalDriver) at the whole list-view (instead of a warning). As a limited editor it is almost impossible to fix this error.

I researched and found out that this problem occurs on some places (more or less).

I use TYPO3 6.2beta5.

I'am not sure if it is related to FAL, but i think it is no tt_news-problem.
To reproduce: Create news and link image (i uploaded it initially). Then i used an regular editor backend user. In list view i got this error.

Related issues

related to Core - Task #56147: Regenerate missing RTE magic image on rendering Needs Feedback 2014-02-20

Associated revisions

Revision 5869277c
Added by Frans Saris over 1 year ago

[BUGFIX] Catch exception in filelist when file is missing

The code responsible for rendering the thumbs belonging to a
record doesn't catch the exceptions when a file couldn't be found.

This change adds a try catch around the functions that
tries to retrieve the file and displays a flash message when
the file is missing.

Resolves: #56077
Releases: 6.2
Change-Id: Icc6550db43c8738c74fd7ea8faac6e99a54bc0f3
Reviewed-on: https://review.typo3.org/28284
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

History

#1 Updated by Thomas Sperling over 1 year ago

I forgott: For reproducing, you have to delete the file of course.

#2 Updated by Frans Saris over 1 year ago

  • Status changed from New to Needs Feedback

For this we added the missing flag feature that is set by the file indexer schedular task.

If you (re)move files direct on filesystem it is recomended to have thuis schedular task run once in a while.

Could you try that and when it still rails post the exception here?

#3 Updated by Markus Klein over 1 year ago

@Frans: Ok, but this is IMO no solution.
What if some person deletes a file and the index regenerated 3 hours later?
In the meantime the BE (and probably other places) is broken.

As a user I'd expect graceful degradation, like a warning somewhere.

#4 Updated by Markus Klein over 1 year ago

  • Status changed from Needs Feedback to Accepted

#5 Updated by Frans Saris over 1 year ago

Markus,

During some testing I found out that the missing flag isn't the solution here. So I agree with you that this should be fix.

Gr. Frans

#6 Updated by Steffen Ritter over 1 year ago

@Markus: that is a solution - if you allow anybody (your server, your editor, ftp -whatever) to manage files OUTSIDE the TYPO3 file module you are obligated to have the indexer task running.

The whole concept of FAL is based on the expectation, that the sys_file table always is sync with the file-system (reliably). This promise needs to be kept.
Everything which goes wrong because this indexer task is not run frequently enough and changes happened outside TYPO3 - it's not a core fault.

If the missing flag at some places is not enough - than we need to improve the usage of that - of course, but not if it even is not flagged as missing.

#7 Updated by Frans Saris over 1 year ago

Problem is that TYPO3\CMS\Backend\Utility\BackendUtility::thumbCode() doesn't catch the exception. Working on a patch for that now.

#8 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28284

#9 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28284

#10 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28284

#11 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28284

#12 Updated by Frans Saris over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF